Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event _time to sources/snapshots/models/seeds #6384

Merged
merged 17 commits into from
Nov 19, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 30, 2024

this pr adds the event_time config to snapshots/seeds/sources/models pages since it's now supported.

this also updates the sources config page as it only mentioned that 'enabled' is supported, but it looks like enabled, event_time, and meta are supported for sources.

this pr will merge into #6383


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 30, 2024 12:58
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 19, 2024 4:49pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Oct 30, 2024
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Oct 30, 2024
@@ -168,6 +168,24 @@ Configurations can be applied to snapshots using [YAML syntax](/docs/build/snaps

<File name='dbt_project.yml'>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grace mentioned event_time is supported for anythign that is ref-able. since snapshot is, i added event_time to it

Sources only support one configuration, [`enabled`](/reference/resource-configs/enabled).
<VersionBlock lastVersion="1.8">

Sources supports [`enabled`](/reference/resource-configs/enabled) and [`meta`](/reference/resource-configs/meta).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the doc mentions source only supports enabled. but other pages show that it supports meta, and not event_time.


<VersionBlock lastVersion="1.8">

Configuring an [`event_time`](/reference/resource-configs/event-time) for a source is only available in dbt Cloud Versionless or dbt Core versions 1.9 and later.
Copy link
Contributor Author

@mirnawong1 mirnawong1 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an example here, does that make sense? tried to keep it with the clickstream example.

</File>

In this example, the `event_time` is set to `event_timestamp`, which has the exact time each clickstream event happened.
Not only is this required for the [incremental microbatching strategy]((/docs/build/incremental-microbatch)), but when you compare data across [CI and production](/docs/deploy/advanced-ci#considerations) environments, dbt will use `event_timestamp` to filter and match data by this event-based timeframe, ensuring that only overlapping timeframes are compared.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This link takes me to a page not found.
I think this is the correct link: /docs/build/incremental-microbatch (I think it might be the double brackets causing the issue)

Kind Regards
Natalie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much @nataliefiann , ok i fixed the link! it was the double parenthesis and also the #considerations is wrong - it should be/docs/deploy/advanced-ci#speeding-up-comparisons instead! great catch!

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this doc. There was one error on the page. The microbatch link in line 279 took me to a page not found. I think this may be because of the double brackets.

Kind Regards
Natalie

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I've approved this for you.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 337248b into add-event-time Nov 19, 2024
4 of 6 checks passed
@mirnawong1 mirnawong1 deleted the update-sources-snapshots branch November 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants