Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add event_time page #6383
add event_time page #6383
Changes from 43 commits
46231b0
33a66a8
6ebf5eb
501d948
4f2c6dc
57ee608
451fc46
3354c9d
603c21c
0c68f62
488460c
2fb62c5
69ba339
1ebbbdb
2b713ee
c789601
5708119
903c5d1
2dd873a
b7a07be
12cdffa
016c555
9c49664
2910914
5ba059e
79128fe
cc34575
551821d
735ae38
ac7616b
bdc037e
0363051
d693c9b
809f2a7
81e2318
14632b3
aad3987
e92c9db
2b98454
3ad1bb6
3da521f
edd1123
52c0db9
f461ffa
a4f3b23
a1c8166
f1969f4
c170a3b
d6a309b
3a8dee5
5851c2b
0656327
57679b2
556249a
0bd8584
bd233ad
b9e4be0
ff3416a
613f1ef
85f181d
4644684
8cf073b
46763d8
d2bf5af
6015dee
4250c9d
76b12e9
de8f752
4b28bbc
337248b
0e16ca6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 22 in website/docs/docs/dbt-versions/release-notes.md
GitHub Actions / vale
[vale] website/docs/docs/dbt-versions/release-notes.md#L22
Raw output
Check warning on line 22 in website/docs/docs/dbt-versions/release-notes.md
GitHub Actions / vale
[vale] website/docs/docs/dbt-versions/release-notes.md#L22
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing this since we call this out in the "scenario" bullet list below
Check warning on line 10 in website/docs/reference/resource-configs/event-time.md
GitHub Actions / vale
[vale] website/docs/reference/resource-configs/event-time.md#L10
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have the "It ensures that..." here but for no other examples? I recommend cutting since we have it above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it was midway through, i was just trying to add a reminder of the effect it has on advanced ci or microbatch. but is overkill so removing