Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reverted DB logo instead of placeholder usage #3541

Merged
merged 9 commits into from
Dec 17, 2024
Merged

refactor: reverted DB logo instead of placeholder usage #3541

merged 9 commits into from
Dec 17, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 2, 2024

Proposed changes

Reverted the step-in DB logo for placeholder logo places.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request labels Dec 2, 2024
@mfranzke mfranzke self-assigned this Dec 2, 2024
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases and removed 📕documentation Improvements or additions to documentation labels Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-reverted-db-logo-instead-of-placeholder-usage

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Dec 15, 2024
@github-actions github-actions bot removed 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Dec 15, 2024
@mfranzke mfranzke mentioned this pull request Dec 16, 2024
Closed
@mfranzke mfranzke marked this pull request as ready for review December 16, 2024 07:59
@mfranzke mfranzke requested a review from bruno-sch as a code owner December 16, 2024 07:59
@mfranzke mfranzke removed their assignment Dec 16, 2024
@mfranzke mfranzke enabled auto-merge (squash) December 16, 2024 08:00
@mfranzke mfranzke disabled auto-merge December 16, 2024 15:54
@mfranzke mfranzke enabled auto-merge (squash) December 16, 2024 15:54
@mfranzke mfranzke disabled auto-merge December 17, 2024 07:19
@mfranzke mfranzke merged commit b17bb92 into main Dec 17, 2024
75 checks passed
@mfranzke mfranzke deleted the refactor-reverted-db-logo-instead-of-placeholder-usage branch December 17, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke