Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reverted DB logo instead of placeholder usage #3541

Merged
merged 9 commits into from
Dec 17, 2024
Merged

refactor: reverted DB logo instead of placeholder usage #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19c68b6
refactor: reverted DB logo instead of placeholder usage
mfranzke Dec 2, 2024
46338db
test: updated screenshots
mfranzke Dec 2, 2024
a86e5ee
Merge branch 'main' into refactor-reverted-db-logo-instead-of-placeho…
mfranzke Dec 2, 2024
d12a66a
Merge branch 'main' into refactor-reverted-db-logo-instead-of-placeho…
mfranzke Dec 15, 2024
a2acef3
test: updated snapshots
mfranzke Dec 15, 2024
d03d48f
refactor: running prettier again
mfranzke Dec 15, 2024
8b5921f
Merge branch 'main' into refactor-reverted-db-logo-instead-of-placeho…
mfranzke Dec 16, 2024
706c609
Merge branch 'main' into refactor-reverted-db-logo-instead-of-placeho…
mfranzke Dec 16, 2024
2f4c5c2
test: updated snapshots
mfranzke Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...m-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
- text: Number
- spinbutton "Number": "123456"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / "
- text: x_placeholder" / "
- link "Requirement arrow_up_right\" / \""
- text: Label
- textbox "Label"
Expand Down
Binary file modified .../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...wcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
- text: Number
- spinbutton "Number": "123456"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / "
- text: x_placeholder" / "
- link "Requirement arrow_up_right\" / \""
- text: Label
- textbox "Label"
Expand Down
Binary file modified ...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...le-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions .../mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
- text: Number
- spinbutton "Number": "123456"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / "
- text: x_placeholder" / "
- link "Requirement arrow_up_right\" / \""
- text: Label
- textbox "Label"
Expand Down
Binary file modified ...le-safari/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions .../mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
- text: Number
- spinbutton "Number": "123456"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / "
- text: x_placeholder" / "
- link "Requirement arrow_up_right\" / \""
- text: Label
- textbox "Label"
Expand Down
Binary file modified ...se/webkit/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions ...howcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
- text: Number
- spinbutton "Number": "123456"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / " Label
- text: x_placeholder" / " Label
- textbox "Label"
- status
- text: db" / "
- text: x_placeholder" / "
- link "Requirement arrow_up_right\" / \""
- text: Label
- textbox "Label"
Expand Down
Binary file modified ...ontrast/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
- text: (Default) Text
- text: (Default) Text
- status
- text: chevron_down" / " db" / " Label
- text: chevron_down" / " x_placeholder" / " Label
- combobox "Label":
- option "Option 1"
- option "Option 2"
Expand Down
Binary file modified ...hromium/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...case/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
- text: (Default) Text
- text: (Default) Text
- status
- text: chevron_down" / " db" / " Label
- text: chevron_down" / " x_placeholder" / " Label
- combobox "Label":
- option "Option 1"
- option "Option 2"
Expand Down
Binary file modified ...-chrome/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
- text: (Default) Text
- text: (Default) Text
- status
- text: chevron_down" / " db" / " Label
- text: chevron_down" / " x_placeholder" / " Label
- combobox "Label":
- option "Option 1"
- option "Option 2"
Expand Down
2 changes: 1 addition & 1 deletion ...mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
- text: (Default) Text
- text: (Default) Text
- status
- text: chevron_down" / " db" / " Label
- text: chevron_down" / " x_placeholder" / " Label
- combobox "Label":
- option "Option 1"
- option "Option 2"
Expand Down
2 changes: 1 addition & 1 deletion ...owcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
- text: (Default) Text
- text: (Default) Text
- status
- text: chevron_down" / " db" / " Label
- text: chevron_down" / " x_placeholder" / " Label
- combobox "Label":
- option "Option 1"
- option "Option 2"
Expand Down
Binary file modified ...trast/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions ...highContrast/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
- tab "(Default) Text": "on"
- text: (Default) Text
- tablist:
- text: db" / "
- tab "db\" / \" Text - Icon (Leading)": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
- text: Text - Icon (Leading)
- tablist:
- tab "Text - Icon (Trailing) db\" / \"": "on"
- text: Text - Icon (Trailing) db" / "
- tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
- text: Text - Icon (Trailing) x_placeholder" / "
- tablist:
- text: db" / "
- tab "db\" / \" Icon": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Icon": "on"
- text: Icon
- link "Behaviour arrow_up_right\" / \""
- tablist:
Expand Down
Binary file modified ...omium/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions ...ase/chromium/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
- tab "(Default) Text": "on"
- text: (Default) Text
- tablist:
- text: db" / "
- tab "db\" / \" Text - Icon (Leading)": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
- text: Text - Icon (Leading)
- tablist:
- tab "Text - Icon (Trailing) db\" / \"": "on"
- text: Text - Icon (Trailing) db" / "
- tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
- text: Text - Icon (Trailing) x_placeholder" / "
- tablist:
- text: db" / "
- tab "db\" / \" Icon": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Icon": "on"
- text: Icon
- link "Behaviour arrow_up_right\" / \""
- tablist:
Expand Down
Binary file modified ...refox/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...hrome/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions ...obile-chrome/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
- tab "(Default) Text": "on"
- text: (Default) Text
- tablist:
- text: db" / "
- tab "db\" / \" Text - Icon (Leading)": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
- text: Text - Icon (Leading)
- tablist:
- tab "Text - Icon (Trailing) db\" / \"": "on"
- text: Text - Icon (Trailing) db" / "
- tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
- text: Text - Icon (Trailing) x_placeholder" / "
- tablist:
- text: db" / "
- tab "db\" / \" Icon": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Icon": "on"
- text: Icon
- link "Behaviour arrow_up_right\" / \""
- tablist:
Expand Down
Binary file modified ...afari/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions ...obile-safari/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
- tab "(Default) Text": "on"
- text: (Default) Text
- tablist:
- text: db" / "
- tab "db\" / \" Text - Icon (Leading)": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
- text: Text - Icon (Leading)
- tablist:
- tab "Text - Icon (Trailing) db\" / \"": "on"
- text: Text - Icon (Trailing) db" / "
- tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
- text: Text - Icon (Trailing) x_placeholder" / "
- tablist:
- text: db" / "
- tab "db\" / \" Icon": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Icon": "on"
- text: Icon
- link "Behaviour arrow_up_right\" / \""
- tablist:
Expand Down
Binary file modified ...ebkit/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions ...wcase/webkit/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
- tab "(Default) Text": "on"
- text: (Default) Text
- tablist:
- text: db" / "
- tab "db\" / \" Text - Icon (Leading)": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
- text: Text - Icon (Leading)
- tablist:
- tab "Text - Icon (Trailing) db\" / \"": "on"
- text: Text - Icon (Trailing) db" / "
- tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
- text: Text - Icon (Trailing) x_placeholder" / "
- tablist:
- text: db" / "
- tab "db\" / \" Icon": "on"
- text: x_placeholder" / "
- tab "x_placeholder\" / \" Icon": "on"
- text: Icon
- link "Behaviour arrow_up_right\" / \""
- tablist:
Expand Down
11 changes: 8 additions & 3 deletions packages/components/src/components/tab-item/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@
active
</label>

<label class="db-tab-item" htmlFor="test3" role="tab" data-icon="db">
<label
class="db-tab-item"
htmlFor="test3"
role="tab"
data-icon="x_placeholder"
>
<input type="radio" name="test" id="test3" />
icon - text (leading)
</label>
Expand All @@ -25,7 +30,7 @@
class="db-tab-item"
htmlFor="test4"
role="tab"
data-icon-after="db"
data-icon-after="x_placeholder"
>
<input type="radio" name="test" id="test4" />
text - icon (trailing)
Expand All @@ -35,7 +40,7 @@
class="db-tab-item"
htmlFor="test5"
role="tab"
data-icon="db"
data-icon="x_placeholder"
data-no-text="true"
>
<input type="radio" name="test" id="test5" />
Expand Down
18 changes: 14 additions & 4 deletions packages/components/src/components/tab-list/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ <h1>Horizontal</h1>
active
</label>

<label class="db-tab" htmlFor="test3" role="tab" data-icon="db">
<label
class="db-tab"
htmlFor="test3"
role="tab"
data-icon="x_placeholder"
>
<input type="radio" name="test" id="test3" />
icon - text (leading)
</label>
Expand All @@ -31,7 +36,7 @@ <h1>Horizontal</h1>
class="db-tab"
htmlFor="test4"
role="tab"
data-icon-after="db"
data-icon-after="x_placeholder"
>
<input type="radio" name="test" id="test4" />
text - icon (trailing)
Expand All @@ -54,7 +59,12 @@ <h1>Vertical</h1>
active
</label>

<label class="db-tab" htmlFor="test3v" role="tab" data-icon="db">
<label
class="db-tab"
htmlFor="test3v"
role="tab"
data-icon="x_placeholder"
>
<input type="radio" name="testv" id="test3v" />
icon - text (leading)
</label>
Expand All @@ -63,7 +73,7 @@ <h1>Vertical</h1>
class="db-tab"
htmlFor="test4v"
role="tab"
data-icon-after="db"
data-icon-after="x_placeholder"
>
<input type="radio" name="testv" id="test4v" />
text - icon (trailing)
Expand Down
8 changes: 4 additions & 4 deletions showcases/shared/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,22 +161,22 @@
"name": "Text - Leading Icon",
"props": {
"label": "Label",
"icon": "db"
"icon": "x_placeholder"
}
},
{
"name": "Text - Leading Icon - Trailing Icon",
"props": {
"label": "Label",
"icon": "db",
"iconAfter": "db"
"icon": "x_placeholder",
"iconAfter": "x_placeholder"
}
},
{
"name": "Text - Trailing Icon",
"props": {
"label": "Label",
"iconAfter": "db"
"iconAfter": "x_placeholder"
}
}
]
Expand Down
2 changes: 1 addition & 1 deletion showcases/shared/select.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@
}
],
"label": "Label",
"icon": "db"
"icon": "x_placeholder"
}
}
]
Expand Down
6 changes: 3 additions & 3 deletions showcases/shared/tab-item.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,20 @@
"name": "Text - Icon (Leading)",
"props": {
"label": "Text - Icon (Leading)",
"icon": "db"
"icon": "x_placeholder"
}
},
{
"name": "Text - Icon (Trailing)",
"props": {
"label": "Text - Icon (Trailing)",
"iconAfter": "db"
"iconAfter": "x_placeholder"
}
},
{
"name": "Icon",
"props": {
"icon": "db",
"icon": "x_placeholder",
"noText": true
}
}
Expand Down
Loading