refactor: reverted DB logo instead of placeholder usage (#3541)

* refactor: reverted DB logo instead of placeholder usage * test: updated screenshots * test: updated snapshots * refactor: running prettier again * test: updated snapshots
db-ui · Dec 17, 2024 · b17bb92 · b17bb92
1 parent a83866d
commit b17bb92
Show file tree

Hide file tree

Showing 35 changed files with 85 additions and 70 deletions.
diff --git a/...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/...m-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/...m-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
@@ -61,16 +61,16 @@
   - text: Number
   - spinbutton "Number": "123456"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / "
+  - text: x_placeholder" / "
   - link "Requirement arrow_up_right\" / \""
   - text: Label
   - textbox "Label"

diff --git a/.../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/.../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/...wcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/...wcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
@@ -61,16 +61,16 @@
   - text: Number
   - spinbutton "Number": "123456"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / "
+  - text: x_placeholder" / "
   - link "Requirement arrow_up_right\" / \""
   - text: Label
   - textbox "Label"

diff --git a/...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/...le-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/...le-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/.../mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/.../mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
@@ -61,16 +61,16 @@
   - text: Number
   - spinbutton "Number": "123456"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / "
+  - text: x_placeholder" / "
   - link "Requirement arrow_up_right\" / \""
   - text: Label
   - textbox "Label"

diff --git a/...le-safari/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/...le-safari/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/.../mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/.../mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
@@ -61,16 +61,16 @@
   - text: Number
   - spinbutton "Number": "123456"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / "
+  - text: x_placeholder" / "
   - link "Requirement arrow_up_right\" / \""
   - text: Label
   - textbox "Label"

diff --git a/...se/webkit/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/...se/webkit/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
diff --git a/...howcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/...howcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
@@ -61,16 +61,16 @@
   - text: Number
   - spinbutton "Number": "123456"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / " Label
+  - text: x_placeholder" / " Label
   - textbox "Label"
   - status
-  - text: db" / "
+  - text: x_placeholder" / "
   - link "Requirement arrow_up_right\" / \""
   - text: Label
   - textbox "Label"

diff --git a/...ontrast/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png b/...ontrast/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
diff --git a/...-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/...-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
@@ -112,7 +112,7 @@
     - text: (Default) Text
   - text: (Default) Text
   - status
-  - text: chevron_down" / " db" / " Label
+  - text: chevron_down" / " x_placeholder" / " Label
   - combobox "Label":
     - option "Option 1"
     - option "Option 2"

diff --git a/...hromium/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png b/...hromium/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
diff --git a/...case/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/...case/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
@@ -112,7 +112,7 @@
     - text: (Default) Text
   - text: (Default) Text
   - status
-  - text: chevron_down" / " db" / " Label
+  - text: chevron_down" / " x_placeholder" / " Label
   - combobox "Label":
     - option "Option 1"
     - option "Option 2"

diff --git a/...-chrome/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png b/...-chrome/DBSelect-should-match-screenshot-1/DBSelect-should-match-screenshot.png
diff --git a/...mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/...mobile-chrome/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
@@ -112,7 +112,7 @@
     - text: (Default) Text
   - text: (Default) Text
   - status
-  - text: chevron_down" / " db" / " Label
+  - text: chevron_down" / " x_placeholder" / " Label
   - combobox "Label":
     - option "Option 1"
     - option "Option 2"

diff --git a/...mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/...mobile-safari/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
@@ -112,7 +112,7 @@
     - text: (Default) Text
   - text: (Default) Text
   - status
-  - text: chevron_down" / " db" / " Label
+  - text: chevron_down" / " x_placeholder" / " Label
   - combobox "Label":
     - option "Option 1"
     - option "Option 2"

diff --git a/...owcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml b/...owcase/webkit/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
@@ -112,7 +112,7 @@
     - text: (Default) Text
   - text: (Default) Text
   - status
-  - text: chevron_down" / " db" / " Label
+  - text: chevron_down" / " x_placeholder" / " Label
   - combobox "Label":
     - option "Option 1"
     - option "Option 2"

diff --git a/...trast/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...trast/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...highContrast/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml b/...highContrast/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
@@ -25,15 +25,15 @@
     - tab "(Default) Text": "on"
     - text: (Default) Text
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Text - Icon (Leading)": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
     - text: Text - Icon (Leading)
   - tablist:
-    - tab "Text - Icon (Trailing) db\" / \"": "on"
-    - text: Text - Icon (Trailing) db" / "
+    - tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
+    - text: Text - Icon (Trailing) x_placeholder" / "
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Icon": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Icon": "on"
     - text: Icon
   - link "Behaviour arrow_up_right\" / \""
   - tablist:

diff --git a/...omium/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...omium/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...ase/chromium/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml b/...ase/chromium/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
@@ -25,15 +25,15 @@
     - tab "(Default) Text": "on"
     - text: (Default) Text
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Text - Icon (Leading)": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
     - text: Text - Icon (Leading)
   - tablist:
-    - tab "Text - Icon (Trailing) db\" / \"": "on"
-    - text: Text - Icon (Trailing) db" / "
+    - tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
+    - text: Text - Icon (Trailing) x_placeholder" / "
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Icon": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Icon": "on"
     - text: Icon
   - link "Behaviour arrow_up_right\" / \""
   - tablist:

diff --git a/...refox/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...refox/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...hrome/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...hrome/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...obile-chrome/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml b/...obile-chrome/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
@@ -25,15 +25,15 @@
     - tab "(Default) Text": "on"
     - text: (Default) Text
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Text - Icon (Leading)": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
     - text: Text - Icon (Leading)
   - tablist:
-    - tab "Text - Icon (Trailing) db\" / \"": "on"
-    - text: Text - Icon (Trailing) db" / "
+    - tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
+    - text: Text - Icon (Trailing) x_placeholder" / "
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Icon": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Icon": "on"
     - text: Icon
   - link "Behaviour arrow_up_right\" / \""
   - tablist:

diff --git a/...afari/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...afari/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...obile-safari/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml b/...obile-safari/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
@@ -25,15 +25,15 @@
     - tab "(Default) Text": "on"
     - text: (Default) Text
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Text - Icon (Leading)": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
     - text: Text - Icon (Leading)
   - tablist:
-    - tab "Text - Icon (Trailing) db\" / \"": "on"
-    - text: Text - Icon (Trailing) db" / "
+    - tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
+    - text: Text - Icon (Trailing) x_placeholder" / "
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Icon": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Icon": "on"
     - text: Icon
   - link "Behaviour arrow_up_right\" / \""
   - tablist:

diff --git a/...ebkit/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png b/...ebkit/DBTabItem-should-match-screenshot-1/DBTabItem-should-match-screenshot.png
diff --git a/...wcase/webkit/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml b/...wcase/webkit/should-have-same-aria-snapshot/DBTabItem-should-have-same-aria-snapshot.yaml
@@ -25,15 +25,15 @@
     - tab "(Default) Text": "on"
     - text: (Default) Text
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Text - Icon (Leading)": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Text - Icon (Leading)": "on"
     - text: Text - Icon (Leading)
   - tablist:
-    - tab "Text - Icon (Trailing) db\" / \"": "on"
-    - text: Text - Icon (Trailing) db" / "
+    - tab "Text - Icon (Trailing) x_placeholder\" / \"": "on"
+    - text: Text - Icon (Trailing) x_placeholder" / "
   - tablist:
-    - text: db" / "
-    - tab "db\" / \" Icon": "on"
+    - text: x_placeholder" / "
+    - tab "x_placeholder\" / \" Icon": "on"
     - text: Icon
   - link "Behaviour arrow_up_right\" / \""
   - tablist:

diff --git a/packages/components/src/components/tab-item/index.html b/packages/components/src/components/tab-item/index.html
@@ -16,7 +16,12 @@
 			active
 		</label>
 
-		<label class="db-tab-item" htmlFor="test3" role="tab" data-icon="db">
+		<label
+			class="db-tab-item"
+			htmlFor="test3"
+			role="tab"
+			data-icon="x_placeholder"
+		>
 			<input type="radio" name="test" id="test3" />
 			icon - text (leading)
 		</label>
@@ -25,7 +30,7 @@
 			class="db-tab-item"
 			htmlFor="test4"
 			role="tab"
-			data-icon-after="db"
+			data-icon-after="x_placeholder"
 		>
 			<input type="radio" name="test" id="test4" />
 			text - icon (trailing)
@@ -35,7 +40,7 @@
 			class="db-tab-item"
 			htmlFor="test5"
 			role="tab"
-			data-icon="db"
+			data-icon="x_placeholder"
 			data-no-text="true"
 		>
 			<input type="radio" name="test" id="test5" />

diff --git a/packages/components/src/components/tab-list/index.html b/packages/components/src/components/tab-list/index.html
@@ -22,7 +22,12 @@ <h1>Horizontal</h1>
 				active
 			</label>
 
-			<label class="db-tab" htmlFor="test3" role="tab" data-icon="db">
+			<label
+				class="db-tab"
+				htmlFor="test3"
+				role="tab"
+				data-icon="x_placeholder"
+			>
 				<input type="radio" name="test" id="test3" />
 				icon - text (leading)
 			</label>
@@ -31,7 +36,7 @@ <h1>Horizontal</h1>
 				class="db-tab"
 				htmlFor="test4"
 				role="tab"
-				data-icon-after="db"
+				data-icon-after="x_placeholder"
 			>
 				<input type="radio" name="test" id="test4" />
 				text - icon (trailing)
@@ -54,7 +59,12 @@ <h1>Vertical</h1>
 				active
 			</label>
 
-			<label class="db-tab" htmlFor="test3v" role="tab" data-icon="db">
+			<label
+				class="db-tab"
+				htmlFor="test3v"
+				role="tab"
+				data-icon="x_placeholder"
+			>
 				<input type="radio" name="testv" id="test3v" />
 				icon - text (leading)
 			</label>
@@ -63,7 +73,7 @@ <h1>Vertical</h1>
 				class="db-tab"
 				htmlFor="test4v"
 				role="tab"
-				data-icon-after="db"
+				data-icon-after="x_placeholder"
 			>
 				<input type="radio" name="testv" id="test4v" />
 				text - icon (trailing)

diff --git a/showcases/shared/input.json b/showcases/shared/input.json
@@ -161,22 +161,22 @@
 				"name": "Text - Leading Icon",
 				"props": {
 					"label": "Label",
-					"icon": "db"
+					"icon": "x_placeholder"
 				}
 			},
 			{
 				"name": "Text - Leading Icon - Trailing Icon",
 				"props": {
 					"label": "Label",
-					"icon": "db",
-					"iconAfter": "db"
+					"icon": "x_placeholder",
+					"iconAfter": "x_placeholder"
 				}
 			},
 			{
 				"name": "Text - Trailing Icon",
 				"props": {
 					"label": "Label",
-					"iconAfter": "db"
+					"iconAfter": "x_placeholder"
 				}
 			}
 		]

diff --git a/showcases/shared/select.json b/showcases/shared/select.json
@@ -316,7 +316,7 @@
 						}
 					],
 					"label": "Label",
-					"icon": "db"
+					"icon": "x_placeholder"
 				}
 			}
 		]

diff --git a/showcases/shared/tab-item.json b/showcases/shared/tab-item.json
@@ -66,20 +66,20 @@
 				"name": "Text - Icon (Leading)",
 				"props": {
 					"label": "Text - Icon (Leading)",
-					"icon": "db"
+					"icon": "x_placeholder"
 				}
 			},
 			{
 				"name": "Text - Icon (Trailing)",
 				"props": {
 					"label": "Text - Icon (Trailing)",
-					"iconAfter": "db"
+					"iconAfter": "x_placeholder"
 				}
 			},
 			{
 				"name": "Icon",
 				"props": {
-					"icon": "db",
+					"icon": "x_placeholder",
 					"noText": true
 				}
 			}
-Original file line number
+Diff line change
@@ Expand Up / @@ -316,7 +316,7 @@ @@
     						}
     					],
     					"label": "Label",
-    					"icon": "db"
+    					"icon": "x_placeholder"
     				}
     			}
     		]
@@ Expand Down @@