Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke FGA roles #5139

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Revoke FGA roles #5139

merged 4 commits into from
Mar 28, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Mar 28, 2024

Fix #5138

This is a prep PR for incoming work on the share dialog actions.

Problem:

The logic for rejecting a pending request is mostly there (although not used), but it's missing the removal of FGA permissions.

Fix:

  1. Add the functions to revoke all user roles (thanks @liady !)
  2. Remove the user from collabs upon rejection (if present)
  3. Added tests

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Try me

Copy link

relativeci bot commented Mar 28, 2024

Job #11341: Bundle Size — 63.24MiB (~-0.01%).

ce41c40(current) vs 2296c28 master#11331(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #11341
     Baseline
Job #11331
Regression  Initial JS 50.42MiB(~+0.01%) 50.42MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.78% 18.76%
No change  Chunks 40 40
No change  Assets 44 44
No change  Modules 4459 4459
No change  Duplicate Modules 598 598
No change  Duplicate Code 31.92% 31.92%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #11341
     Baseline
Job #11331
Regression  JS 63.22MiB (~+0.01%) 63.22MiB
Improvement  HTML 14.15KiB (-0.44%) 14.21KiB

View job #11341 reportView feat/revoke-fga-relations branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 4705e45 into master Mar 28, 2024
17 checks passed
@ruggi ruggi deleted the feat/revoke-fga-relations branch March 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revoke FGA permissions on rejections
3 participants