Remix projects access requests actions dropdown #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # utopia-remix/app/routes-test/internal.projects.$id.access.request.$token.destroy.spec.ts
Job #11383: Bundle Size — 63.39MiB (~-0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
|
| Current Job #11383 |
Baseline Job #11381 |
|
|---|---|---|
 Initial JS |
50.43MiB(~+0.01%) |
50.43MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.88% |
22.25% |
| Chunks |
41 |
41 |
| Assets |
45 |
45 |
| Modules |
4469 |
4469 |
| Duplicate Modules |
608 |
608 |
| Duplicate Code |
32.05% |
32.05% |
| Packages |
467 |
467 |
| Duplicate Packages |
58 |
58 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current Job #11383 |
Baseline Job #11381 |
|
|---|---|---|
| JS |
63.38MiB (~+0.01%) |
63.38MiB |
| HTML |
14.15KiB (-0.44%) |
14.21KiB |
View job #11383 report View feat/share-access-dropdown branch activity View project dashboard
|
Performance test results: |
bkrmendy
approved these changes
Apr 2, 2024
liady
approved these changes
Apr 2, 2024
Rheeseyb
reviewed
Apr 2, 2024
| // the access requests, including in-flight optimistic statuses | ||
| const [accessRequests, setAccessRequests] = React.useState(props.accessRequests) | ||
| // the last successfully-obtained access requests that can be used to roll-back in case of issues when updating requests | ||
| const [stableAccessRequests, setStableAccessRequests] = React.useState(props.accessRequests) |
There was a problem hiding this comment.
This should probably be called previousAccessRequests
Rheeseyb
reviewed
Apr 2, 2024
| return ( | ||
| <DropdownMenu.Root> | ||
| <DropdownMenu.Trigger> | ||
| {/* this needs to be inlined (and as a ternary) because DropdownMenu.Trigger requires a direct single child */} |
There was a problem hiding this comment.
Maybe we should pull it out into its own component in that case?
There was a problem hiding this comment.
yeah my comment is meant for that case too: it needs an explicit inline child, because otherwise it will explode due to the component not accepting refs (?!). You can see I tried doing it here but had to revert it back :( 645b73a (#5155)
Rheeseyb
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5140
Builds on top of #5139 and #5142 .
Problem:
It should be possible to manipulate access requests for collaborative projects besides the basic approve of a new request.
Fix:
This PR adds a dropdown to the sharing dialog, per collaborator row. The dropdown allows the user to approve, reject, or discard access requests. The different options change depending on the current status of the request. For pending requests, the button has a yellow-orange accent background.