Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remix: destroy access requests #5142

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Remix: destroy access requests #5142

merged 2 commits into from
Apr 2, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Mar 28, 2024

Fix #5141

This is a prep PR following up from #5139.

  • Add logic for destroying an existing access request
  • Add a route for that
  • Add tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 28, 2024 •
edited
Loading

Job #11357: Bundle Size — 63.39MiB (~-0.01%).

b9aa7a6(current) vs 2296c28 master#11346(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #11357		      Baseline
Job #11346
Regression  Initial JS 50.43MiB(~+0.01%) 50.43MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.88% 21.54%
No change  Chunks 41 41
No change  Assets 45 45
No change  Modules 4469 4469
No change  Duplicate Modules 608 608
No change  Duplicate Code 32.05% 32.05%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #11357		      Baseline
Job #11346
Regression  JS 63.38MiB (~+0.01%) 63.38MiB
Improvement  HTML 14.15KiB (-0.44%) 14.21KiB

View job #11357 report View feat/destroy-access-request branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit b47cd40 into master Apr 2, 2024
16 checks passed
@ruggi ruggi deleted the feat/destroy-access-request branch April 2, 2024 08:39
@ruggi ruggi mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liady liady liady approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destroy access requests
3 participants
@ruggi @balazsbajorics @liady