-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Lock numpy to < 2.0.0 across all reqs and pyproject.toml #2360
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Re: docs, I want to add a lot more detail in our contribution docs. I've started doing so on some of my other PRs, and I'll make a note to do it for dependency management as well. |
Not sure I follow - what are contribution docs? This - https://docs.trychroma.com/contributing? |
Yes, though also maybe we should mention it in the list of migrations. Unclear where to put it just now. |
…a-core#2360) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Numpy 2.0 has some type changes which break our code. This was flagged by @itayB in chroma-core#2352 (Thank you!). We need to extend that PR a bit to include other requirements for the thin client, as well as the pyproject.toml. - Note: We could fix these type issues but Onnxruntime does not yet support python 2.0 - which we depend on (microsoft/onnxruntime#21063) - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes We may want to update our docs? I am not sure what makes sense here - input solicited.
Is this released? Which release will this be launched with? we are having issues in our production chroma servers cc @HammadB |
@amanAtHoneyHealth This has landed as of 0.5.3 - have you updated? What issues are you seeing? |
I haven't updated yet. I am using an older client 0.4.10 so and I know that 0.5.1 and 0.5.2 did not work with older clients. This is the error I am seeing with my chroma server version 0.4.21
What would you suggest I do? I need a quickest solution since its affecting our production users rn |
The fastest solution is to downgrade your installed numpy version to What's the reason for using older client / server versions? Migrations are detailed here in our docs and it's highly recommended to upgrade. |
Thanks @atroyn I was able to make it working by bumping the chroma version to 0.5.3. I will look into migrating server to a higher version as recommended. |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
We may want to update our docs? I am not sure what makes sense here - input solicited.