Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Lock numpy to < 2.0.0 across all reqs and pyproject.toml #2360

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jun 17, 2024

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

We may want to update our docs? I am not sure what makes sense here - input solicited.

@HammadB HammadB requested a review from atroyn June 17, 2024 18:05
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB enabled auto-merge (squash) June 17, 2024 18:05
@atroyn
Copy link
Contributor

atroyn commented Jun 17, 2024

Re: docs, I want to add a lot more detail in our contribution docs. I've started doing so on some of my other PRs, and I'll make a note to do it for dependency management as well.

@HammadB
Copy link
Collaborator Author

HammadB commented Jun 17, 2024

Not sure I follow - what are contribution docs? This - https://docs.trychroma.com/contributing?

@HammadB HammadB merged commit aceffb4 into main Jun 17, 2024
64 checks passed
@atroyn
Copy link
Contributor

atroyn commented Jun 17, 2024

Not sure I follow - what are contribution docs? This - https://docs.trychroma.com/contributing?

Yes, though also maybe we should mention it in the list of migrations. Unclear where to put it just now.

Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
…a-core#2360)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Numpy 2.0 has some type changes which break our code. This was flagged
by @itayB in chroma-core#2352 (Thank you!). We need to extend that PR a bit to
include other requirements for the thin client, as well as the
pyproject.toml.
- Note: We could fix these type issues but Onnxruntime does not yet
support python 2.0 - which we depend on
(microsoft/onnxruntime#21063)
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
We may want to update our docs? I am not sure what makes sense here -
input solicited.
@amanAtHoneyHealth
Copy link

Is this released? Which release will this be launched with? we are having issues in our production chroma servers cc @HammadB

@atroyn
Copy link
Contributor

atroyn commented Jul 7, 2024

@amanAtHoneyHealth This has landed as of 0.5.3 - have you updated? What issues are you seeing?

@amanAtHoneyHealth
Copy link

@amanAtHoneyHealth This has landed as of 0.5.3 - have you updated? What issues are you seeing?

I haven't updated yet. I am using an older client 0.4.10 so and I know that 0.5.1 and 0.5.2 did not work with older clients.

This is the error I am seeing with my chroma server version 0.4.21

  File "/usr/local/lib/python3.10/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead.. Did you mean: 'float16'?

What would you suggest I do? I need a quickest solution since its affecting our production users rn

@atroyn
Copy link
Contributor

atroyn commented Jul 8, 2024

The fastest solution is to downgrade your installed numpy version to 1.26.4 or earlier in your Chroma virtual env.

What's the reason for using older client / server versions? Migrations are detailed here in our docs and it's highly recommended to upgrade.

@amanAtHoneyHealth
Copy link

Thanks @atroyn I was able to make it working by bumping the chroma version to 0.5.3. I will look into migrating server to a higher version as recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants