Skip to content

Commit

Permalink
[BUG] Lock numpy to < 2.0.0 across all reqs and pyproject.toml (chrom…
Browse files Browse the repository at this point in the history
…a-core#2360)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Numpy 2.0 has some type changes which break our code. This was flagged
by @itayB in chroma-core#2352 (Thank you!). We need to extend that PR a bit to
include other requirements for the thin client, as well as the
pyproject.toml.
- Note: We could fix these type issues but Onnxruntime does not yet
support python 2.0 - which we depend on
(microsoft/onnxruntime#21063)
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
We may want to update our docs? I am not sure what makes sense here -
input solicited.
  • Loading branch information
HammadB authored and Anush008 committed Jun 27, 2024
1 parent fce40bf commit 87edad5
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion clients/python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ classifiers = [
"Operating System :: OS Independent",
]
dependencies = [
'numpy >= 1.22.5',
'numpy >= 1.22.5, < 2.0.0',
'opentelemetry-api>=1.2.0',
'opentelemetry-exporter-otlp-proto-grpc>=1.2.0',
'opentelemetry-sdk>=1.2.0',
Expand Down
2 changes: 1 addition & 1 deletion clients/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
numpy >= 1.22.5
numpy >= 1.22.5, < 2.0.0
opentelemetry-api>=1.2.0
opentelemetry-exporter-otlp-proto-grpc>=1.2.0
opentelemetry-sdk>=1.2.0
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies = [
'chroma-hnswlib==0.7.3',
'fastapi >= 0.95.2',
'uvicorn[standard] >= 0.18.3',
'numpy >= 1.22.5',
'numpy >= 1.22.5, < 2.0.0',
'posthog >= 2.4.0',
'typing_extensions >= 4.5.0',
'onnxruntime >= 1.14.1',
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ httpx>=0.27.0
importlib-resources
kubernetes>=28.1.0
mmh3>=4.0.1
numpy>=1.22.5
numpy>=1.22.5, <2.0.0
onnxruntime>=1.14.1
opentelemetry-api>=1.2.0
opentelemetry-exporter-otlp-proto-grpc>=1.24.0
Expand Down

0 comments on commit 87edad5

Please sign in to comment.