-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Chroma crash with the new numpy version - update requirements.txt #2352
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Thanks for flagging we will cut a new release this week to patch this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this. Was successfully able to reproduce, and this is due to Chroma using now deprecated generic types in some of our multimodal datatypes:
Line 102 in cc790a7
ImageDType = Union[np.uint, np.int_, np.float_] |
This is an easy fix, but unfortunately on further testing I found that onnxruntime
which is upstream of us is also broken by numpy 2.0.
Pinning the version is probably the way to go! Let's keep the previous requirement to be above 1.22.5, while introducing this new one too.
done, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same happens here now: #2356
I didn’t see this in my testing but will check again. |
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Numpy 2.0 has some type changes which break our code. This was flagged by @itayB in #2352 (Thank you!). We need to extend that PR a bit to include other requirements for the thin client, as well as the pyproject.toml. - Note: We could fix these type issues but Onnxruntime does not yet support python 2.0 - which we depend on (microsoft/onnxruntime#21063) - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes We may want to update our docs? I am not sure what makes sense here - input solicited.
…a-core#2360) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Numpy 2.0 has some type changes which break our code. This was flagged by @itayB in chroma-core#2352 (Thank you!). We need to extend that PR a bit to include other requirements for the thin client, as well as the pyproject.toml. - Note: We could fix these type issues but Onnxruntime does not yet support python 2.0 - which we depend on (microsoft/onnxruntime#21063) - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes We may want to update our docs? I am not sure what makes sense here - input solicited.
Description of changes
Summarize the changes made by this PR.
Suggesting locking before version 2 as a first Aid