Introduce OM to T1 project #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
force-pushed
the
binder-om
branch
3 times, most recently
from
6169a1e to
7a529e3
Compare
SpriteOvO
force-pushed
the
binder-om
branch
4 times, most recently
from
93be2ca to
249cc30
Compare
sequencer
requested changes
May 1, 2024
| }) | ||
| } | ||
|
|
||
| def dumpAll(): Unit = { |
There was a problem hiding this comment.
Suggested change
| def dumpAll(): Unit = { | |
| def dumpOM(): Unit = { |
There was a problem hiding this comment.
what's the purpose of this function?
There was a problem hiding this comment.
Dump the whole tree of the input instantiated OM object.
omreader/src/Main.scala
Outdated
Comment on lines
18
to
22
| def run( | ||
| @arg(name = "mlirbc-file") mlirbcFile: Option[os.Path], | ||
| @arg(name = "class-name") className: String, | ||
| @arg(name = "dump-methods") dumpMethods: Flag, | ||
| @arg(name = "eval") eval: Option[String], | ||
| ) = { |
There was a problem hiding this comment.
I prefer API to be as simple as possible, this API is used by doc/PnR/DV guys. We should statically maintain them.
def dumpOM(
@arg(name = "mlirbc-file") mlirbcFile: os.Path,
@arg(name = "class-name") className: String,
): String = ???
def vlen(
@arg(name = "mlirbc-file") mlirbcFile: os.Path,
@arg(name = "class-name") className: String,
): String = ???
def dlen(
@arg(name = "mlirbc-file") mlirbcFile: os.Path,
@arg(name = "class-name") className: String,
): String = ???
mlirbcFile: just usemlirbcFile, we generally don't use read from stdin.classNameshould be automatically detected, users don't need know what Class is, or force it to be fixed.
There was a problem hiding this comment.
Makes sense. I have pushed a commit for it, could you review it again please?
SpriteOvO
force-pushed
the
binder-om
branch
2 times, most recently
from
fa36604 to
3d87d85
Compare
sequencer
requested changes
May 6, 2024
omreader/src/Main.scala
Outdated
| println(simplyGetT1Reader(mlirbcFile).dlen) | ||
| } | ||
|
|
||
| def simplyGetT1Reader(mlirbcFile: os.Path) = OMReader.fromFile(mlirbcFile, "T1Subsystem_Class").t1Reader |
There was a problem hiding this comment.
We need to support both T1_Class and T1Subsystem_Class
SpriteOvO
force-pushed
the
binder-om
branch
2 times, most recently
from
9f09ce2 to
4ae371d
Compare
sequencer
requested changes
May 7, 2024
SpriteOvO
force-pushed
the
binder-om
branch
2 times, most recently
from
638f5ca to
ee38539
Compare
|
This bump doesn't include the 1.74 version of circt... |
sequencer
approved these changes
May 7, 2024
|
Cc @SharzyL this api is used to handle all metadatas our c header and emu should use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR: chipsalliance/chisel#4028