Caliptra core 2.0 HW spec updates #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatpillilli
requested review from
calebofearth,
mojtaba-bisheh and
upadhyayulakiran
calebofearth
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Fix this typo? dilitium
Remove the entire section on UART/QSPI?
Is the KeyVault interface update known for ML-DSA?
Should these integration spec sections also be updated (remove qspi/uart)?
…s, added intr vecs
|
|
@Nitsirks - let me know if you want me to update the KV thing @calebofearth mentioned above and I can do that since you may already know what you are doing and launch this PR. If you want to do it as a part of your PR, I will send this in so that you can make doc change on top of it without having conflicts |
mojtaba-bisheh
approved these changes
Oct 30, 2024
calebofearth
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.