refactor: establish target.Reconciler #378
Merged
+118
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cert-manager-prow
bot
added
do-not-merge/work-in-progress
erikgb
changed the title
cert-manager-prow
bot
added
size/XXL
|
/test all |
cert-manager-prow
bot
added
size/XL
|
/test all |
3 similar comments
|
/test all |
|
/test all |
|
/test all |
erikgb
changed the title
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
|
/cc @inteon |
erikgb
force-pushed
the
target-reconciler
branch
2 times, most recently
from
ed14b07
to
98b51c9
Compare
cert-manager-prow
bot
added
size/XL
erikgb
force-pushed
the
target-reconciler
branch
from
9f441d8
to
e6d182a
Compare
cert-manager-prow
bot
added
the
needs-rebase
erikgb
force-pushed
the
target-reconciler
branch
from
e6d182a
to
b36f9c2
Compare
cert-manager-prow
bot
removed
the
needs-rebase
This was referenced Aug 14, 2024
cert-manager-prow
bot
added
the
needs-rebase
erikgb
force-pushed
the
target-reconciler
branch
from
b36f9c2
to
7a34242
Compare
cert-manager-prow
bot
added
size/L
erikgb
force-pushed
the
target-reconciler
branch
3 times, most recently
from
b5b2443
to
adf3daf
Compare
cert-manager-prow
bot
added
the
needs-rebase
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
target-reconciler
branch
from
adf3daf
to
f3ddd4a
Compare
cert-manager-prow
bot
removed
the
needs-rebase
erikgb
changed the title
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
SgtCoDFish
approved these changes
Sep 19, 2024
Comment on lines
+370
to
373
| type Data struct { | ||
| Data string | ||
| BinaryData map[string][]byte | ||
| } |
There was a problem hiding this comment.
comment: Looking at this now, I think we could use better names. Obviously it's not related to this PR, but Data.PEM and Data.Binary or something would be more descriptive and avoid echoing Data.Data 🤔
There was a problem hiding this comment.
Agreed! I can try to fix this in one of my follow-up PRs.
There was a problem hiding this comment.
Ah, the data struct is unlike the non-data struct. 😄
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the bundle target area. The main motivation is to prepare the grounds for #58 and #222.
The refactoring became larger because I had to move some fields and functions to avoid circular package dependencies. I would be happy to split these changes out in pre-PRs if desired.Multiple pre-PRs merged now.