refactor: move FieldManager to more available package #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
erikgb
commented
Jul 20, 2024
| ) | ||
|
|
||
| const ( | ||
| FieldManager = client.FieldOwner("trust-manager") |
There was a problem hiding this comment.
This constant seems a bit "misplaced", but I didn't want to create a new Go-file for just this...
inteon
reviewed
Aug 14, 2024
erikgb
force-pushed
the
refactor-fieldmanager
branch
from
6a273e4
to
bdc202e
Compare
inteon
reviewed
Aug 14, 2024
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
refactor-fieldmanager
branch
from
bdc202e
to
d0647cb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some additional improvements that made sense when doing this. The main motivation is to reduce the size of #378, as I need the
FieldManagerconstant available in a new package without getting circular dependencies.The package name
ssa_clientannoys me a bit. 😉 I think the name should be justclient. I was tempted to change this, but let's leave it for now - as it will require us to resolve package name import conflicts. It should be possible to do by creating type aliases in ourclientpackage. I've seen that c/r does this a lot.