refactor: reduce duplication in sync target functions #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
erikgb
force-pushed
the
refactor-sync-target
branch
3 times, most recently
from
00468de
to
acb6f3c
Compare
|
I have now attempted to reduce duplication even more using generics, but I am not too happy with the result. Go generics is not the generics I am used to. 😉 PTAL @inteon! |
erikgb
force-pushed
the
refactor-sync-target
branch
from
acb6f3c
to
2809cea
Compare
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
refactor-sync-target
branch
from
2809cea
to
38dd335
Compare
inteon
reviewed
Sep 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this refactoring is to move the deletion of target configmap/secret out of the patch functions. The end goal is to provide functions that can be reused in the new pull-target feature I am working on. When the user creates the target resource, it does not make sense for trust-manager to delete it (as a side effect of patching it).
I have renamed some variables to avoid shadowing in #378.
Relates to #378