Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging to minimal with test #347

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

Found during the data conversion workshop, specific to NeuroConv, but noticed it might also apply here too

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 13, 2024
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodyCBakerPhD
Copy link
Member Author

Failures in https://github.com/catalystneuro/roiextractors/actions/runs/9603499178/job/26486881927 evidence that we do indeed need packaging in minimal these days

@pauladkisson
Copy link
Member

Can you add this PR to the changelog as well?

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) June 20, 2024 20:16
@CodyCBakerPhD CodyCBakerPhD disabled auto-merge June 20, 2024 20:17
@CodyCBakerPhD CodyCBakerPhD reopened this Jun 20, 2024
@pauladkisson pauladkisson merged commit 4d98f31 into main Jun 20, 2024
36 of 56 checks passed
@pauladkisson pauladkisson deleted the add_test_for_packaging branch June 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants