Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging to minimal with test #347

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Add packaging to minimal with test #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9512d49
add test for packaging
CodyCBakerPhD Jun 13, 2024
ec29b79
properly adjust first minimal
CodyCBakerPhD Jun 20, 2024
87e0e67
Merge branch 'main' into add_test_for_packaging
CodyCBakerPhD Jun 20, 2024
05de8a0
add packaging to minimal
CodyCBakerPhD Jun 20, 2024
a300f4c
Update CHANGELOG.md
CodyCBakerPhD Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ jobs:
git config --global user.name "CI Almighty"

- name: Install roiextractors with minimal requirements
run: pip install .[test]
run: pip install .
- name: Test initial import of all non-lazy dependencies
run: python -c "import roiextractors"

- name: Install roiextractors with testing requirements
pauladkisson marked this conversation as resolved.
Show resolved Hide resolved
run: pip install .[test]
- name: Run minimal tests
run: pytest tests/test_internals -n auto --dist loadscope

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340)
* Change the criteria of determining if Bruker data is volumetric [#342](https://github.com/catalystneuro/roiextractors/pull/342)
* Fixes a bug that assumes the channel name is is on the tiff file for `BrukerTiffSinglePlaneImagingExtractor` [#343](https://github.com/catalystneuro/roiextractors/pull/343)
* Including `packaging` explicitly in minimal requirements [#347](https://github.com/catalystneuro/roiextractors/pull/347)

### Improvements

Expand Down
1 change: 1 addition & 0 deletions requirements-minimal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ scipy>=1.5.2
psutil>=5.8.0
PyYAML
lxml
packaging
Loading