Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wheel requirement and remove testing dependencies from the CI. #348

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Remove wheel requirement and remove testing dependencies from the CI. #348

merged 2 commits into from
Jun 20, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Jun 13, 2024 •
edited
Loading

Three things in the PR:

@h-mayorquin h-mayorquin requested a review from pauladkisson June 13, 2024 20:55
@h-mayorquin h-mayorquin self-assigned this Jun 13, 2024
@h-mayorquin
Copy link
Collaborator Author

Also related to the tests added in #347 (review)

pauladkisson
pauladkisson approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @h-mayorquin!

@pauladkisson pauladkisson merged commit f6fc44a into main Jun 20, 2024
29 checks passed
@pauladkisson pauladkisson deleted the remove_whell_instalation branch June 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-mayorquin @pauladkisson