Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): ensure custom L0 nav items work #11547

Merged
merged 11 commits into from
Feb 29, 2024
Merged

fix(masthead): ensure custom L0 nav items work #11547

merged 11 commits into from
Feb 29, 2024

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented Feb 16, 2024 •
edited
Loading

Related Ticket(s)

none

Description

#11420 ensures support for customizing the L0 nav items, but it doesn't account for the navLinks property. This PR adds that support, and it also includes a test to make sure L0 customization is working as expected.

To test

  1. Visit this Codepen example: https://codepen.io/jakaeser/pen/LYavrKK
  2. See that the custom L0 nav items are not applying.
  3. Comment out the v2 latest CDN <script>, then uncomment the deploy preview CDN <script>
  4. Verify the custom L0 nav items apply.
  5. In the Pen's JS, replace the l0Data property with navLinks. Verify the custom L0 items still apply.

Changelog

New

  • Adds an e2e test for customizing L0 items.

Changed

  • Supports navLinks property when using <c4d-masthead-container> and customizing L0 items.
  • Corrects the prefixes used in masthead e2e tests.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11547/index.html

Built with commit: d405eb73a01aada924d5ad7f15c3397b61f3ece0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11547/index.html

Built with commit: d405eb73a01aada924d5ad7f15c3397b61f3ece0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11547/index.html

Built with commit: d405eb73a01aada924d5ad7f15c3397b61f3ece0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11547/index.html

Built with commit: d405eb73a01aada924d5ad7f15c3397b61f3ece0

@jkaeser jkaeser added package: web components Work necessary for the IBM.com Library web components package owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Feb 16, 2024
@jkaeser jkaeser marked this pull request as ready for review February 16, 2024 20:39
@jkaeser jkaeser requested a review from a team as a code owner February 16, 2024 20:39
@jkaeser jkaeser requested review from kennylam and sangeethababu9223 and removed request for a team February 16, 2024 20:39
@jkaeser jkaeser added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Feb 20, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 20, 2024 •
edited
Loading

Deploy preview created for package Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11547/index.html

Built with commit: d405eb73a01aada924d5ad7f15c3397b61f3ece0

m4olivei
m4olivei approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed testing instructions. All looks good to me!

annawen1
annawen1 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for making it so easy to test like Matt mentioned!!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Feb 29, 2024
@kodiakhq kodiakhq bot merged commit 07a1223 into carbon-design-system:main Feb 29, 2024
13 of 20 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.5.0.

@kennylam kennylam mentioned this pull request Mar 13, 2024
Open
@kennylam kennylam self-assigned this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@m4olivei m4olivei m4olivei approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees

@kennylam kennylam

Labels
👀 eyes needed owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkaeser @ibmdotcom-bot @m4olivei @annawen1 @kennylam