-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(masthead): ensure custom L0 nav items work (#11547)
### Related Ticket(s) none ### Description #11420 ensures support for customizing the L0 nav items, but it doesn't account for the `navLinks` property. This PR adds that support, and it also includes a test to make sure L0 customization is working as expected. ## To test 1. Visit this Codepen example: https://codepen.io/jakaeser/pen/LYavrKK 2. See that the custom L0 nav items are not applying. 3. Comment out the v2 latest CDN <script>, then uncomment the deploy preview CDN <script> 4. Verify the custom L0 nav items apply. 5. In the Pen's JS, replace the `l0Data` property with `navLinks`. Verify the custom L0 items still apply. ### Changelog **New** - Adds an e2e test for customizing L0 items. **Changed** - Supports `navLinks` property when using `<c4d-masthead-container>` and customizing L0 items. - Corrects the prefixes used in masthead e2e tests. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
- Loading branch information
Showing
4 changed files
with
110 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.