FEATURE: add isolation forest algorithm #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narumiruna
requested review from
c9s,
ycdesu,
kbearXD,
gx578007 and
bailantaotao
|
Welcome back! @narumiruna, This pull request may get 633 BBG. |
narumiruna
force-pushed
the
narumi/iforest/init
branch
from
7254820 to
18e6e1a
Compare
|
Re-estimated karma: this pull request may get 793 BBG |
narumiruna
force-pushed
the
narumi/iforest/init
branch
from
18e6e1a to
cc14507
Compare
|
Re-estimated karma: this pull request may get 798 BBG |
|
Re-estimated karma: this pull request may get 822 BBG |
narumiruna
force-pushed
the
narumi/iforest/init
branch
from
1e500f2 to
1493234
Compare
|
Re-estimated karma: this pull request may get 874 BBG |
ycdesu
reviewed
Jan 3, 2025
|
|
||
| // SetDefaultValues initializes zero-valued fields in Options with defaults. | ||
| func (o *Options) SetDefaultValues() { | ||
| if o.DetectionType == "" { |
There was a problem hiding this comment.
The method name and comment do not indicate that it only sets default values when the value is not zero value. Should we remove all the if conditions?
There was a problem hiding this comment.
If we remove all the if conditions, then it will overrides the non-zero options in NewWithOptions.
narumiruna
force-pushed
the
narumi/iforest/init
branch
from
1493234 to
1e1ca23
Compare
|
Re-estimated karma: this pull request may get 900 BBG |
narumiruna
force-pushed
the
narumi/iforest/init
branch
from
1e1ca23 to
43997f8
Compare
|
Re-estimated karma: this pull request may get 868 BBG |
ycdesu
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cs.nju.edu.cn/zhouzh/zhouzh.files/publication/icdm08b.pdf