Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename as per PEP 8 #189

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

cpaniaguam
Copy link
Member

General module renaming. A few changed files but straightforward to review.

@cpaniaguam cpaniaguam self-assigned this Mar 7, 2024
@cpaniaguam cpaniaguam linked an issue Mar 7, 2024 that may be closed by this pull request
@cpaniaguam cpaniaguam linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of changes in the pyproject.toml file

icesat2-tracks => icesat2waves
min python ver => 3.10
TODO: rename repo
@cpaniaguam cpaniaguam requested a review from hollandjg March 7, 2024 21:48
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment on lines -162 to -164
"Homepage" = "https://github.com/brown-ccv/icesat2-tracks"
"Bug Reports" = "https://github.com/brown-ccv/icesat2-tracks/issues"
"Source" = "https://github.com/brown-ccv/icesat2-tracks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to rename the repo to make this consistent. New issue for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can take care of that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpaniaguam cpaniaguam mentioned this pull request Mar 11, 2024
2 tasks
@cpaniaguam cpaniaguam merged commit c9ee0f3 into main Mar 11, 2024
2 checks passed
@cpaniaguam cpaniaguam deleted the 30-rename-icesat2_si_tools-folder branch March 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ICEsat2_SI_tools folder
2 participants