Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ICEsat2_SI_tools Module to tools for PEP 8 Compliance #136

Closed
wants to merge 4 commits into from

Conversation

cpaniaguam
Copy link
Member

This PR addresses the renaming of the ICEsat2_SI_tools module to tools in order to comply with PEP 8 naming conventions. PEP 8 recommends module names to be short, lowercase, and avoid underscores if possible.

Changes

  • Renamed ICEsat2_SI_tools module to tools
  • Updated all import statements and references to use the new module name

Files updated

Files in the old ICEsat2_SI_tools directory and relevant files in the analysis_db directory.

src/icesat2_tracks/analysis_db/A02c_IOWAGA_thredds_prior.py
src/icesat2_tracks/analysis_db/B01_SL_load_single_file.py
src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py
src/icesat2_tracks/analysis_db/B03_plot_spectra_ov.py
src/icesat2_tracks/analysis_db/B04_angle.py
src/icesat2_tracks/analysis_db/B05_define_angle.py
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py
src/icesat2_tracks/tools/__init__.py
src/icesat2_tracks/tools/angle_optimizer.py
src/icesat2_tracks/tools/beam_stats.py
src/icesat2_tracks/tools/convert_GPS_time.py
src/icesat2_tracks/tools/convert_julian.py
src/icesat2_tracks/tools/filter_regrid.py
src/icesat2_tracks/tools/generalized_FT.py
src/icesat2_tracks/tools/iotools.py
src/icesat2_tracks/tools/lanczos.py
src/icesat2_tracks/tools/read_ground_tracks.py
src/icesat2_tracks/tools/sliderule_converter_tools.py
src/icesat2_tracks/tools/spectral_estimates.py
src/icesat2_tracks/tools/spicke_remover.py
src/icesat2_tracks/tools/wave_tools.py

@kmilo9999
Copy link
Collaborator

Can we merge this PR after #132 ?
That one has some changes in those files's code.

hollandjg
hollandjg previously approved these changes Mar 1, 2024
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cpaniaguam
Copy link
Member Author

Can we merge this PR after #132 ? That one has some changes in those files's code.

Surely!

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cpaniaguam
Copy link
Member Author

Completed in #189

@cpaniaguam cpaniaguam closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants