Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 2.0 website issues. #224

Merged
merged 39 commits into from
Feb 15, 2024
Merged

Address 2.0 website issues. #224

merged 39 commits into from
Feb 15, 2024

Conversation

mike-ferguson
Copy link
Member

@mike-ferguson mike-ferguson commented Jan 22, 2024

Addressed the issues I am tagged under in here. As this PR is in web and 431 is on vision, I cannot PR onto it directly.

Specifically, this PR:

  • Has clearer error messages on invalid zip failures
  • Applies styling to invalid_zip.html and already_submitted.html
  • Adds a picture of a correct submission package to invalid_zip failures
  • Refactors some of the invalid_zip logic to be more coherent
  • Removes brain/base models option for vision, but keeps public option
  • Adds type hints and docstrings to invalid_zip methods (originally written awhile ago without them)
  • Adds styling to vision submission to make it inline with vision
  • Adds dedicated page to warn user not to submit a tutorial file
  • Adds tutorial file to tutorial
  • Updates tutorial to tell users to not actually submit the file
  • Removes old navbar boilerplate code from html pages
  • Overhauls Tutorial Main page styling to match themes
  • Overhauls Quickstart page styling to match themes
  • Overhauls Deep Dive 1 page styling to match themes
  • Corrects Deep Dive 1 material to remove changing identifiers, etc
  • Overhauls Deep Dive 2 page styling to match themes
  • Overhauls Deep Dive 3 page styling to match themes
  • Update font for leaderboard side panels
  • fix resubmission job name from run_benchmarks to score_plugins
  • reject all submissions >50MB
  • Change Team -> Contributors, link to here
  • PoInt Support (Footer) to Community page

@mike-ferguson
Copy link
Member Author

mike-ferguson commented Jan 26, 2024

Updated styling for an example faulty submission (models folder is empty):

Screenshot 2024-01-26 at 9 32 01 AM

Copy link
Collaborator

@kvfairchild kvfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes/clarifications, but at a higher level: I'm not sure if it makes sense to keep the deep dive tutorial the way it currently is structured, which (even if we're not actually making the submission) is geared towards creating a duplicate of an existing model under a different identifier. We could maybe just drop the identifier changing activities and have it be just a walkthrough of the example submission?

benchmarks/templates/benchmarks/invalid_zip.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/upload.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/upload.html Outdated Show resolved Hide resolved
benchmarks/views/user.py Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/already_submitted.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/invalid_zip.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/upload.html Outdated Show resolved Hide resolved
benchmarks/views/user.py Outdated Show resolved Hide resolved
benchmarks/views/user.py Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/tutorial_deepdive_1.html Outdated Show resolved Hide resolved
benchmarks/views/user.py Show resolved Hide resolved
Copy link
Collaborator

@kvfairchild kvfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't have as much time as I'd like to spend on this review, so while it generally looks good to me, I'm holding out approval for now and hoping a few other sets of eyes can make up the difference!

benchmarks/templates/benchmarks/community.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/community.html Outdated Show resolved Hide resolved
benchmarks/templates/benchmarks/community.html Outdated Show resolved Hide resolved
Copy link
Member Author

@mike-ferguson mike-ferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all changes

Copy link
Member Author

@mike-ferguson mike-ferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason Git was showing an unresolved issue when there was none, so I had to dismiss your previous review @mschrimpf, but all your changes were indeed addressed

@kvfairchild kvfairchild merged commit 667711b into master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tutorial about brain-score code for development vs. submission for leaderboard
4 participants