Removed public/private submissions and brain/base models for vision #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschrimpf
reviewed
Feb 4, 2024
Comment on lines
-43
to
-44
| public = forms.BooleanField(label='Make model scores public (can be changed later):', required=False, | ||
| help_text='Check if you want the results of your submitted models included in the public ranking.') |
There was a problem hiding this comment.
I'm confused why we want to remove this; this has nothing to do with whether or not the code/weights are public. @kvfairchild I feel like there's a breakdown in communication somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick hot fix to remove the private submission option as well as the old brain/base model submission option in Vision.
This PR is a minimal change - the rest (making it in line with Language) is addressed in #224.