Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin duplicate protection (identifiers and directory names) #237

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Plugin duplicate protection (identifiers and directory names) #237

merged 9 commits into from
Feb 22, 2024

Conversation

samwinebrake
Copy link
Contributor

@samwinebrake samwinebrake commented Feb 13, 2024 •
edited
Loading

  • added extract_identifiers to find patterns within plugin inits
  • changed variable naming within is_submission_original
  • duplicate protection of plugin identifiers within inits

@mike-ferguson and @shehadak will this work with new changes being pushed shortly?

Closes #223

@samwinebrake
- added extract_identifiers to find patterns within plugin inits
c5f41b2 
- changed variable naming within is_submission_original
- duplicate protection of directory names and plugin identifiers
@samwinebrake samwinebrake linked an issue Feb 13, 2024 that may be closed by this pull request
Prevent duplicate plugin submissions by plugin identifier before zipfile is accepted for submission #223
Closed
@samwinebrake samwinebrake self-assigned this Feb 13, 2024
@samwinebrake samwinebrake reopened this Feb 13, 2024
@samwinebrake samwinebrake requested review from mike-ferguson, kvfairchild and shehadak and removed request for kvfairchild February 13, 2024 19:34
mike-ferguson
mike-ferguson reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@mike-ferguson mike-ferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one comment, see attached

benchmarks/views/user.py Outdated Show resolved Hide resolved
@mike-ferguson
Copy link
Member

Also: #224 Is almost merged, once tests pass. I say hold off on merging this PR and let's fold in those changes from #224 into here and do a quick test. I don't think anything will conflict, but it will be good to check

shehadak
shehadak reviewed Feb 14, 2024
View reviewed changes
benchmarks/views/user.py Outdated Show resolved Hide resolved
@shehadak
Copy link
Collaborator

LGTM as well once comments are resolved! :-)

@samwinebrake samwinebrake merged commit 523d04c into master Feb 22, 2024
2 checks passed
@samwinebrake samwinebrake deleted the sw/plugin-identifier-duplicate-protection branch February 22, 2024 15:07
@pellegreene pellegreene mentioned this pull request Mar 5, 2024
Closed
@kvfairchild kvfairchild mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shehadak shehadak shehadak approved these changes

@mike-ferguson mike-ferguson Awaiting requested review from mike-ferguson

Assignees

@samwinebrake samwinebrake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent duplicate plugin submissions by plugin identifier before zipfile is accepted for submission
3 participants
@samwinebrake @mike-ferguson @shehadak