Optional dependency on binary via package flags
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornbm
reviewed
Aug 20, 2024
bjornbm
reviewed
Aug 20, 2024
|
Thanks @LaurentRDC! For the record, what “environment” (GHC, etc.) did you test in? FYI I ran a build on LTS Haskell 20.24 (ghc-9.2.7) and tested with |
|
I tested exclusively with GHC 9.10.1 |
|
For my next contribution, I'll set up Github Actions for multiple GHC versions ;) |
|
Thanks @LaurentRDC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a continuation of #111 , but only for the
binarypackage (andBinaryinstances).I restricted to
binarybecause this is what I use and could test quickly; happy to add more instances and flags if people are interested.99% of this work was done by @dmcclean ; thank you!