Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To/FromJSON instance #192

Open
picca opened this issue Aug 31, 2018 · 2 comments
Open

To/FromJSON instance #192

picca opened this issue Aug 31, 2018 · 2 comments

Comments

@picca
Copy link

picca commented Aug 31, 2018

It would be great if we could serialize unserialize via Aeson dimensionnal values.

for now we have this.

• No instance for (FromJSON
                     (dimensional-1.0.1.3:Numeric.Units.Dimensional.Internal.Dimensional
                        'Numeric.Units.Dimensional.Variants.DQuantity
                        Numeric.Units.Dimensional.Dimensions.TypeLevel.DLength
                        Double))
    arising from a use of ‘aeson-1.2.4.0:Data.Aeson.Types.FromJSON.$dmparseJSON’

thanks for considering

@bjornbm
Copy link
Owner

bjornbm commented Nov 8, 2018

I have no objections but would appreciate a patch if you want it sooner rather than later (I guess it already is “later” – sorry). I'm thinking it will have to rely on Numeric.Units.Dimensional.Dynamic and should probably go in dimensional-dk-experimental or a package of its own.

@LaurentRDC
Copy link
Collaborator

If someone wants to work on this, this PR can be used as a template: #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants