Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions workflow with doctests #225

Merged
merged 9 commits into from
Aug 21, 2024

Conversation

LaurentRDC
Copy link
Collaborator

@LaurentRDC LaurentRDC commented Aug 20, 2024

This is a simple Github Actions workflow that ensures that dimensional can be built for a variety of GHC versions and flags. It supercedes #218.

Currently, only one set of flags is tested (the trivial one); this PR should be merged after #224 .

I have specified a reasonable set of GHC versions; happy to expand or contract the list.

This is a draft pull request because I wasn't able to make the documentation tests work in Github Actions. I will need to test on a different machine.

@LaurentRDC LaurentRDC changed the title Basic Github Actions workflow Github Actions workflow with doctests Aug 21, 2024
@LaurentRDC
Copy link
Collaborator Author

LaurentRDC commented Aug 21, 2024

The doctests have now been updated to pass, which fixes #220 .

I couldn't get the 'test suite' version to pass; instead, I used the doctest command line which is recommended:

cabal repl dimensional --build-depends=QuickCheck --with-ghc=doctest

As you can see here, it works fine

@LaurentRDC LaurentRDC marked this pull request as ready for review August 21, 2024 00:54
@bjornbm bjornbm merged commit a19a94e into bjornbm:master Aug 21, 2024
@LaurentRDC
Copy link
Collaborator Author

@bjornbm I made a small mistake; cabal needs to use the constraint command-line option, not flags.

See here for a small patch: LaurentRDC@c735f7a

@bjornbm
Copy link
Owner

bjornbm commented Aug 21, 2024

OK, could you do a pull request for the correction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants