This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Add Export Services from Climate Change Lab #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddohler
commented
Mar 29, 2019
| * | ||
| * @param parentSelector - Name of parent of chart, used to rewrite CSS selectors | ||
| */ | ||
| private chartOptions(parentSelector: string) { |
There was a problem hiding this comment.
This used to be an object; apologies for including the switch to a function in the same commit that brings it over into the repo. There was a lot of friction to getting the Components repo linked in to both Temperate and the Lab, and by the time I got everything working, the WiP commits weren't in a place where it was super easy to split that functionality change apart. I'm happy to dive in and break this apart if you want to keep the commit history clean.
This was referenced Mar 29, 2019
- Upgrades to latest version of save-svg-as-png to fix an issue with downloading PNGs - Adds a `selector` parameter to ImageExportService.downloadAsPNG() that can be used to dynamically remap CSS selectors; the previous value was hardcoded such that it worked only in the Lab.
ddohler
force-pushed
the
feature/dpd/add-export-services
branch
from
a307b13 to
daa5c0b
Compare
|
Fixed up the integrity deletions in |
maurizi
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows
DataExportServiceandImageExportServiceservices to be used in both the Lab and Temperate.Notes
This includes a modification to the
ImageExportServiceto allow passing in the CSS selector for the chart's parent. This allows it to work in both Temperate and the Lab; previously it used a hard-coded value that only worked for the Lab.Testing Instructions
Checklist
yarn run lintclean?yarn run build:libraryclean?npm packclean?CHANGELOG.mdupdated?Connects azavea/temperate#1171