Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Add PNG Chart export #1210

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Add PNG Chart export #1210

merged 2 commits into from
Apr 3, 2019

Conversation

ddohler
Copy link
Contributor

@ddohler ddohler commented Mar 29, 2019

Overview

Allows users to export charts as PNGs.

Demo

DownloadTemperate

Notes

This is WiP until azavea/climate-change-components#51 is merged and a new version is released. After that happens, this should be updated to pull in the latest version in package.json, and remove the dependencies for SVG export and file saving. The TEMP: DO NOT MERGE commit also will need to be removed.

Testing Instructions

Either

Or

Then

  • vagrant ssh and then scripts/updated followed by scripts/server
  • Either way, then vagrant ssh and scripts/server
  • Load up the app, and click on every graph you can find and make sure that there is 1) A Download button 2) That the download button works and 3) That it downloads a valid PNG that reflects the chart.
  • Is the CHANGELOG.md updated with any relevant additions, changes, fixes or removals following the format of keepachangelog?

Closes #1171

@ddohler ddohler requested a review from maurizi March 29, 2019 19:49
@ddohler ddohler force-pushed the feature/dpd/add-chart-png-export branch from 1f46c96 to a961350 Compare April 3, 2019 15:48
@ddohler ddohler changed the title WiP: Add PNG Chart export Add PNG Chart export Apr 3, 2019
@ddohler
Copy link
Contributor Author

ddohler commented Apr 3, 2019

This has been updated and is ready for review.

@ddohler ddohler force-pushed the feature/dpd/add-chart-png-export branch from a961350 to 0346ef9 Compare April 3, 2019 16:17
@maurizi
Copy link
Contributor

maurizi commented Apr 3, 2019

Is the border around the section the Download button is in an intentional design decision?
It feels like a styling bug to me:
image

TimeAggParam
TimeAggParam,
DataExportService,
ImageExportService,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports are making the linter unhappy (need to be aphabetized)

@ddohler
Copy link
Contributor Author

ddohler commented Apr 3, 2019

Good call on the border; it never really registered as a problem for me (but I totally see what you mean), but when I looked into it, it was because of a directive that had snuck into the HTML that was no longer necessary in Temperate, so I took it out.

@ddohler ddohler requested a review from maurizi April 3, 2019 20:07
@ddohler ddohler force-pushed the feature/dpd/add-chart-png-export branch from 9c2775d to 392945c Compare April 3, 2019 20:10
@ddohler ddohler merged commit 567895c into develop Apr 3, 2019
@maurizi maurizi deleted the feature/dpd/add-chart-png-export branch April 3, 2019 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user ability to download indicator graphs
3 participants