This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ddohler
force-pushed
the
feature/dpd/add-chart-png-export
branch
from
April 3, 2019 15:48
1f46c96
to
a961350
Compare
This has been updated and is ready for review. |
ddohler
force-pushed
the
feature/dpd/add-chart-png-export
branch
from
April 3, 2019 16:17
a961350
to
0346ef9
Compare
maurizi
reviewed
Apr 3, 2019
TimeAggParam | ||
TimeAggParam, | ||
DataExportService, | ||
ImageExportService, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These imports are making the linter unhappy (need to be aphabetized)
Good call on the border; it never really registered as a problem for me (but I totally see what you mean), but when I looked into it, it was because of a directive that had snuck into the HTML that was no longer necessary in Temperate, so I took it out. |
maurizi
approved these changes
Apr 3, 2019
ddohler
force-pushed
the
feature/dpd/add-chart-png-export
branch
from
April 3, 2019 20:10
9c2775d
to
392945c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows users to export charts as PNGs.
Demo
Notes
This is WiP until azavea/climate-change-components#51 is merged and a new version is released. After that happens, this should be updated to pull in the latest version in package.json, and remove the dependencies for SVG export and file saving. TheTEMP: DO NOT MERGE
commit also will need to be removed.Testing Instructions
EitherCheck out the code from Add Export Services from Climate Change Lab climate-change-components#51 in your development environment for that project.In the CC components repo, runyarn run build:library
Check out03b3bcb
and runvagrant up
and thenvagrant ssh
andscripts/update
Check outb6051ef
and runvagrant reload
OrFollow these instructions to pull in a copy of theclimate-change-components
repo: Use distance parameter for climate API calls #1179Thenvagrant ssh
and thenscripts/updated
followed byscripts/server
Either way, thenvagrant ssh
andscripts/server
Closes #1171