This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Use ExportServices from climate-change-components #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Brief description of what this PR does, and why it is needed.
Demo
Notes
climate-change-components
, I discovered that therxjs
import migration here was incomplete. Becauseclimate-change-components
importsObservable
the wrong way, it allows things to work that won't work onceclimate-change-components
importsObservable
correctly. I didn't end up merging the changes toclimate-change-components
that triggered these failures (precisely because they caused unexpected problems in other places and I didn't want to risk breaking unrelated functionality in Temperate and the Lab), but the additional imports here are (apparently) harmless and they prevent us from having to redo the work whenever Use recommendedrxjs
import form climate-change-components#49 gets resolved.package.json
, and remove the dependencies for SVG export and file saving.Testing Instructions
yarn run build:library
yarn install
rsync -avrc --delete ../climate-change-components/lib-dist/ node_modules/climate-change-components/lib-dist/
<-- Substitute the path to yourclimate-change-components
repo if that isn't correct.yarn run serve
and confirm that you can still download PNGs of charts and that you get no compilation errors.Checklist
yarn run serve
clean?yarn run build:prod
clean?yarn run lint
clean?Connects azavea/temperate#1171