Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor examples to leverage terraform-aws-eks for cluster creation #1074

Closed
wants to merge 15 commits into from
Closed

chore: Refactor examples to leverage terraform-aws-eks for cluster creation #1074

wants to merge 15 commits into from

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Oct 23, 2022 •
edited
Loading

What does this PR do?

  • Refactor examples to leverage terraform-aws-eks for cluster creation
  • Add recommended security group rules for node groups - this is planned to be available as a default in v19 of terraform-aws-modules

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

bryantbiggs
bryantbiggs commented Oct 23, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
bryantbiggs
bryantbiggs commented Oct 23, 2022
View reviewed changes
examples/complete-kubernetes-addons/main.tf
@@ -178,40 +111,6 @@ module "eks_blueprints_kubernetes_addons" {
]
}

enable_fargate_fluentbit = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to fargate-serverless

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 23, 2022 16:42 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 23, 2022 20:44 Inactive
@bryantbiggs
Copy link
Contributor Author

failed plans will fail since those are removed or re-named

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 25, 2022 13:38 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 25, 2022 15:27 Inactive
Zvikan
Zvikan reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one! LGTM, some minor comments and questions here.
Let's make sure to run the e2e across the examples and do some sanity checks to all the running resources per example, feel free to pull me in so we can divide and conquer this.

.github/workflows/e2e-parallel-destroy.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-parallel-full.yml Outdated Show resolved Hide resolved
examples/ai-ml/ray/main.tf Outdated Show resolved Hide resolved
examples/ai-ml/ray/main.tf
@@ -344,13 +333,11 @@ module "vpc" {
default_security_group_tags = { Name = "${local.name}-default" }

public_subnet_tags = {
"kubernetes.io/cluster/${local.name}" = "shared"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that needed for automatic subnet discovery by LBs or ingress controllers? or since in this example we don't use any then we can safely remove

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 28, 2022 23:12 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 28, 2022 23:21 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 29, 2022 12:46 Inactive
@bryantbiggs
fix: Gatekeeper security group rules, ensure node groups are ready be…
af6ed77 
…fore provisioning addons, CI is clean before provisioning
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 30, 2022 15:56 Inactive
@bryantbiggs bryantbiggs marked this pull request as draft October 30, 2022 15:56
@bryantbiggs
Copy link
Contributor Author

switching to draft to split up PR

@bryantbiggs bryantbiggs mentioned this pull request Oct 31, 2022
Merged
6 tasks
@bryantbiggs bryantbiggs mentioned this pull request Oct 31, 2022
Merged
6 tasks
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 20:31 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 21:10 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 21:14 Inactive
@bryantbiggs bryantbiggs closed this Nov 3, 2022
@bryantbiggs bryantbiggs deleted the refactor/example-clusters branch November 3, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zvikan Zvikan Zvikan left review comments

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Create Log Stream due to Double Quote
2 participants
@bryantbiggs @Zvikan