Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove examples that are related to EKS Blueprints cluster modules #1104

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Oct 31, 2022

What does this PR do?

  • Remove the following examples:
    • ingress-controllers/nginx - doesn't provide additional value beyond enabling the addon, addon is shown in other examples already
    • node-groups/* - no longer required due to use of terraform-aws-eks module
    • portworx - doesn't provide additional value beyond enabling the addon, currently does not work due to the IAM policy (should use IRSA but currently does not support)
    • upstream-with-k8s-addons - no longer required since nearly all examples will be following this approach (soon)
    • gitlab-ci-cd - this example didn't show anything relevant to EKS and instead just demonstrated using GitLab for Terraform remote state management. A proper example is slated to be implemented in [BLUEPRINT]Replace gitlab-ci-cd with an example that shows self-hosted GitLab on EKS #493

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 18:24 Inactive
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 7df3824 into main Oct 31, 2022
@bryantbiggs bryantbiggs deleted the chore/remove-examples branch October 31, 2022 19:07
@Zvikan Zvikan mentioned this pull request Nov 7, 2022
6 tasks
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants