Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI to move scripts to script folder and ensure CloudWatch logs are deleted before applying #1105

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Oct 31, 2022

What does this PR do?

  • Update versions used in GitHub actions to remove set-output warnings; not all actions have been updated at this time so not all warnings are removed yet
  • Move CI scripts to scripts directory
  • Add step + script to ensure CloudWatch logs are deleted (if they exist) before deploying e2e workflow
  • Move agones example up one directory to remove game-tech from path (flatten structure a bit)

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 31, 2022 19:58 Inactive
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 7c6f16d into main Oct 31, 2022
@bryantbiggs bryantbiggs deleted the chore/ci-updates branch October 31, 2022 20:25
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants