try to fix broken logo and favicon

[pjfanning]

see apache/pekko-site#95

needs more testing before merging

[pjfanning]

@samueleresca @mdedetrich I built this locally and then used it in pekko-grpc paradox build (also locally) - but none of the assets.hostname dependent paths were mapped - all the links are relative. This includes the existing paths that already support assets.hostname.

edit - I tested with pekko-site repo and these changes seem to work there

[samueleresca]

@samueleresca @mdedetrich I built this locally and then used it in pekko-grpc paradox build (also locally) - but none of the assets.hostname dependent paths were mapped - all the links are relative. This includes the existing paths that already support assets.hostname.

edit - I tested with pekko-site repo and these changes seem to work there

Have you tried to also specify the assets.hostname property into the downstream module (e.g.: paradoxProperties in incubator-pekko-(http|grpc))

I would expect the changes in this PR would fix the problem. The assets.hostname is specified at theme level and the logo element was not including the base path. The other bit that worries me is the $page.base$ part appended after the assets.hostname porperty, which might be the cause of the issue.

I can take a look at this tomorrow

[pjfanning]

The $page.properties.("assets.hostname")$$page.base$ pattern is already used in https://github.com/apache/incubator-pekko-sbt-paradox/blob/d47e88d12a922d678048306d9b069106162cb00f/theme/src/main/assets/page.st#L57

and other places in this file

[mdedetrich]

I can take a look at this tomorrow

Ill wait till tomorrow to see if there is an update on this

[Roiocam]

I doubt that this is related to #86. I'm not sure if page.properties ("assets.hostname") exists, but using it with $page.base$ may be a bad idea.

[Roiocam]

The icon link of all modules is broken, but the pekko homepage is not, which also proves this. $page.base$ is the path of a specific project.

[Roiocam]

The link is to https://pekko.apache.org/docs/pekko-http/current/assets/images/pekko_logo.png

Should be https://pekko.apache.org/assets/images/pekko_logo.png

The previous comments should be no problem. $page.base$ is not a problem. At present, it is always the root directory of the project, that is.

The documents generated by all these modules (http, connector, pekko) are "assets/xxxx", even if the string template adds assets.home, but due to pekko, conn Ector These modules do not have the default value of assets.home, so they still do not point the path to CDN.

So I think the PR needs to set a default value for assets.home, or explicitly add the assets.home configuration value for each project.

[pjfanning]

seems to be included in #127

[samueleresca]

Added an issue tracking the page.base paths in the static assets: #128