Update sbt-pekko-paradox #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
raboof,
gmethvin,
He-Pin,
nvollmar,
samueleresca,
pjfanning,
Roiocam and
jxnu-liguobin
|
sbt-paradox has issues - can we hold off on doing uptake PRs - see apache/pekko-sbt-paradox#126 - but there may also be more issues |
mdedetrich
force-pushed
the
update-pekko-sbt-paradox
branch
from
0508a1a
to
ac665b6
Compare
|
@pjfanning I have just updated the PR to include latest snapshot which has the favicon fix but we don't have to merge it right now |
samueleresca
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version does not require all of the workarounds
Also ran
locally to confirm that it works