Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken image links with latest pekko-sbt-paradox snapshots #95

Closed
pjfanning opened this issue Mar 3, 2024 · 4 comments
Closed

broken image links with latest pekko-sbt-paradox snapshots #95

pjfanning opened this issue Mar 3, 2024 · 4 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Mar 3, 2024

See https://pekko.apache.org/docs/pekko-http/current/ and look at top left

image

The Pekko Logo has broken

The link is to https://pekko.apache.org/docs/pekko-http/current/assets/images/pekko_logo.png

Should be https://pekko.apache.org/assets/images/pekko_logo.png

Also - the Pekko favicon seems to not be working - probably a similar issue.

@pjfanning
Copy link
Contributor Author

pjfanning commented Mar 3, 2024

@samueleresca @mdedetrich would either of you be in a position to look into this? I don't know if other images are affected or if it is just the logo icon. So far, the Pekko icon is the only thing I've seen but it is pretty front and centre on the web site.

@samueleresca
Copy link
Member

@samueleresca
Copy link
Member

So, I think the root cause of this was that some of the partials weren't overwritten in incubator-pekko-sbt-paradox. Therefore, some of the links where leading to 404, Refer to the PR above for the fix.

@pjfanning
Copy link
Contributor Author

fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants