Fix bug for issue #68 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to error-check-test
…der ion-js folder. Cleaned server.ts file.
… vsocde=languageserver dependency.
…to error-check
…to error-check
…es for formatting.
…ics.test.ts file.
… test cases for formatting.
…to error-check
…to error-check
|
This PRs title is "Error check". It's not a descriptive title for what the PR is actually fixing. Can you update the title please |
therapon
reviewed
Aug 21, 2020
Comment on lines
+42
to
+46
| documents.onDidClose (e => { | ||
| let diagnostics: Diagnostic[] = []; | ||
| connection.sendDiagnostics ({ uri: e.document.uri, diagnostics }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Any way we can write a test to verify that the behaviour is what we want?
There was a problem hiding this comment.
I think with the 'extest' framework, this can probably get done.
There was a problem hiding this comment.
I think with the 'extest' framework, this can probably get done.
either add the test to this pr or open an issue to add the test later
therapon
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #68 :
Description of changes:
Fixed bug from #68 .