Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for issue #68 #70

Merged
merged 31 commits into from
Sep 15, 2020
Merged

Fix bug for issue #68 #70

Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3c720c5
Added ion-js API for error reporting.
lziq Jul 30, 2020
0d6eb68
Added test suite for error checking.
lziq Jul 31, 2020
1f2d079
Merge branch 'master' of https://github.com/amzn/ion-vscode-plugin in…
lziq Aug 1, 2020
27dcbcf
Error message for blob and clob.
lziq Aug 4, 2020
d683a5a
Fixed test case failure.
lziq Aug 4, 2020
3302223
Fixed test case failure.
lziq Aug 4, 2020
f14b1af
Put error checking test cases under test folder. Put IonText files un…
lziq Aug 5, 2020
26eabc0
Put highlighting test cases under test folder. Updated for the latest…
lziq Aug 5, 2020
76d3ade
Deleted more comments.
lziq Aug 5, 2020
ae6988c
Deleted error message parsing functionality. Created test cases for t…
lziq Aug 5, 2020
0211ea8
Merge branch 'master' of https://github.com/amzn/ion-vscode-plugin in…
lziq Aug 6, 2020
3d6cdf3
Added more test cases.
lziq Aug 6, 2020
d12a67c
Merged from remote master
lziq Aug 8, 2020
528e068
Merge branch 'master' of https://github.com/amzn/ion-vscode-plugin in…
lziq Aug 10, 2020
d1b070a
Merged from remote master
lziq Aug 10, 2020
2a335b5
Added test cases for formatting.
lziq Aug 10, 2020
8a79aac
Changed the range of textDocument for formatting. Added more test cas…
lziq Aug 11, 2020
45cbf25
Fixed a bug for the last commit: Comment out all the code in diagnost…
lziq Aug 11, 2020
5f157b5
Added function to count the number of lines for formatting.
lziq Aug 11, 2020
4f5ff33
Changed the way to get line number for formatting feature. Added more…
lziq Aug 11, 2020
d312818
Added more test cases for formatting.
lziq Aug 11, 2020
071e8dd
Remove some test cases for formatting.
lziq Aug 11, 2020
18ed2ea
Removed some test cases for formatting.
lziq Aug 11, 2020
3d35666
Added more test cases for formatting.
lziq Aug 11, 2020
3729b4c
Merge branch 'master' of https://github.com/amzn/ion-vscode-plugin in…
lziq Aug 11, 2020
57768aa
Changed version. Changed README.
lziq Aug 12, 2020
e753b06
Changed the version in package-lock.json file. Changed README file.
lziq Aug 12, 2020
8b8c9df
Forcing package-lock.json file to change. Changed README.
lziq Aug 13, 2020
225b643
Changed README.
lziq Aug 13, 2020
3a040ba
Merge branch 'master' of https://github.com/amzn/ion-vscode-plugin in…
lziq Aug 13, 2020
6b4dfcf
Fixed bug for persistent problems.
lziq Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ documents.onDidChangeContent(change => {
validateTextDocument(change.document);
});

documents.onDidClose (e => {
let diagnostics: Diagnostic[] = [];
connection.sendDiagnostics ({ uri: e.document.uri, diagnostics });
});

Comment on lines +42 to +46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can write a test to verify that the behaviour is what we want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the 'extest' framework, this can probably get done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the 'extest' framework, this can probably get done.

either add the test to this pr or open an issue to add the test later

// custom implementation of ANTLR's ErrorListener
class CustomErrorListener {
private diagnostics: Diagnostic[] = [];
Expand Down