Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening/Closing Bad Ion File Has Persistent "Problems" #68

Closed
almann opened this issue Aug 19, 2020 · 1 comment · Fixed by #70
Closed

Opening/Closing Bad Ion File Has Persistent "Problems" #68

almann opened this issue Aug 19, 2020 · 1 comment · Fixed by #70
Labels
bug Something isn't working

Comments

@almann
Copy link

almann commented Aug 19, 2020

When opening an Ion file with errors outside of a workspace, then closing it, the "problems" remain. Not sure if this works as designed, or a bug.

  1. Open a new window.
  2. Open a file with bad Ion.
  3. Close the file.

Doing this causes the "problems" of the now closed file to remain. This seems wrong to me--but it could be a misunderstanding on my part around VS Code's model.

image
@therapon
Copy link
Contributor

Tried the same steps for a JSON file. The problems tab is cleared when the faulting JSON file is closed.

@therapon therapon added the bug Something isn't working label Aug 19, 2020
@lziq lziq linked a pull request Aug 24, 2020 that will close this issue
Fix bug for issue #68 #70
Merged
@lziq lziq mentioned this issue Aug 28, 2020
Merged
therapon pushed a commit that referenced this issue Sep 15, 2020
@lziq
Fix bug for issue #68 (#70)
492ded0 
* Added ion-js API for error reporting.

* Added test suite for error checking.

* Error message for blob and clob.

* Fixed test case failure.

* Fixed test case failure.

* Put error checking test cases under test folder. Put IonText files under ion-js folder. Cleaned server.ts file.

* Put highlighting test cases under test folder. Updated for the latest vsocde=languageserver dependency.

* Deleted more comments.

* Deleted error message parsing functionality. Created test cases for timestamp.

* Added more test cases.

* Merged from remote master

* Merged from remote master

* Added test cases for formatting.

* Changed the range of textDocument for formatting. Added more test cases for formatting.

* Fixed a bug for the last commit: Comment out all the code in diagnostics.test.ts file.

* Added function to count the number of lines for formatting.

* Changed the way to get line number for formatting feature. Added more test cases for formatting.

* Added more test cases for formatting.

* Remove some test cases for formatting.

* Removed some test cases for formatting.

* Added more test cases for formatting.

* Changed version. Changed README.

* Changed the version in package-lock.json file. Changed README file.

* Forcing package-lock.json file to change. Changed README.

* Changed README.

* Fixed bug for persistent problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug for issue #68 amazon-ion/ion-vscode-plugin
2 participants
@therapon @almann