Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(robot-model): add clamp_in_range function for individual JointStateVariable #199

Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat(robot-model): add clamp_in_range function for individual JointStateVariable #199

merged 6 commits into from
Oct 28, 2024

Conversation

bpapaspyros
Copy link
Member

Description

This PR solves the issue by adding the function in the Model class and its corresponding python bindings.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Related issues

Blocked by:

Blocks:

@bpapaspyros bpapaspyros self-assigned this Oct 17, 2024
@bpapaspyros bpapaspyros linked an issue Oct 17, 2024 that may be closed by this pull request
Add clamp_in_range for specific cartesian field rather than all fields #194
Closed
@bpapaspyros bpapaspyros changed the base branch from main to feat/joint_state_utilities October 17, 2024 11:44
@bpapaspyros

This comment was marked as outdated.

Sign in to view
Base automatically changed from feat/joint_state_utilities to main October 17, 2024 15:00
@bpapaspyros bpapaspyros marked this pull request as ready for review October 17, 2024 15:11
domire8
domire8 previously approved these changes Oct 28, 2024
View reviewed changes
source/robot_model/src/Model.cpp Outdated Show resolved Hide resolved
domire8
domire8 previously approved these changes Oct 28, 2024
View reviewed changes
@bpapaspyros bpapaspyros merged commit fa5dea7 into main Oct 28, 2024
5 checks passed
@bpapaspyros bpapaspyros deleted the feat/clamp_in_range branch October 28, 2024 09:35
@bpapaspyros bpapaspyros restored the feat/clamp_in_range branch October 28, 2024 09:36
@bpapaspyros bpapaspyros deleted the feat/clamp_in_range branch October 28, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@domire8 domire8 domire8 approved these changes

@eeberhard eeberhard Awaiting requested review from eeberhard

Assignees

@bpapaspyros bpapaspyros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clamp_in_range for specific cartesian field rather than all fields
2 participants
@bpapaspyros @domire8