Create the Operation common component. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 8, 2024
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 8, 2024
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 8, 2024
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 8, 2024
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 8, 2024
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
rofrankel
added a commit
to aep-dev/aeps
that referenced
this pull request
Mar 11, 2024
* Clean up and modernize AIP-151: Long-running operations. The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8. * lint * Update creation date * Update aep/general/0151/aep.yaml Co-authored-by: Yusuke Tsutsumi <[email protected]> --------- Co-authored-by: Yusuke Tsutsumi <[email protected]>
jeremyfiel
reviewed
Mar 15, 2024
| If true, the operation is completed, and either response or error | ||
| is available. | ||
| error: | ||
| $ref: '#/components/schemas/Error' |
There was a problem hiding this comment.
this doesn't resolve to anything and you don't have the schema defined with the same language as the markdown description. Error and response are mutually exclusive in the text, but not here.
| @@ -0,0 +1,32 @@ | |||
| Operation: | |||
There was a problem hiding this comment.
no $schema, title, description, or $id defined for this schema.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Google's
google.longrunning.Operation.