Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Operation common component. #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions json_schema/api/operation.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
Operation:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no $schema, title, description, or $id defined for this schema.

description: The status of a long running operation.
properties:
path:
type: string
description:
The server-assigned path, which is only unique within the same
service that originally returns it.
done:
type: boolean
description: >-
If the value is false, it means the operation is still in progress.
If true, the operation is completed, and either response or error
is available.
error:
$ref: '#/components/schemas/Error'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't resolve to anything and you don't have the schema defined with the same language as the markdown description. Error and response are mutually exclusive in the text, but not here.

metadata:
type: object
description: >-
Service-specific metadata associated with the operation. It typically
contains progress information and common metadata such as create time.
Some services might not provide such metadata. Any method that returns a
long-running operation should document the metadata type, if any.
response:
type: object
description: >-
The normal response of the operation in case of success.
Depending on the method, this may be the empty object, the resource on which
the operation is performed, or a custom response.
required:
- path
- done
257 changes: 257 additions & 0 deletions proto/aep-api/aep/api/operation.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,257 @@
// Copyright 2019 Google LLC.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Modification notice: This file has been modified from its original form as
// part of the AEP.dev project (https://aep.dev). The above copyright notice is
// retained in order to provide attribution to Google LLC for the original
// version of this file.

syntax = "proto3";

package aep.api;

import "google/api/annotations.proto";
import "google/api/client.proto";
import "google/protobuf/any.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/empty.proto";
import "google/rpc/status.proto";
import "google/protobuf/descriptor.proto";

option cc_enable_arenas = true;
option csharp_namespace = "Aep.Api";

Check failure on line 33 in proto/aep-api/aep/api/operation.proto

View workflow job for this annotation

GitHub Actions / buf

Files in package "aep.api" have both values "Aep.Api" and no value for option "csharp_namespace" and all values must be equal.
option go_package = "aep.dev/api/longrunning;longrunning";

Check failure on line 34 in proto/aep-api/aep/api/operation.proto

View workflow job for this annotation

GitHub Actions / buf

Files in package "aep.api" have multiple values "aep.dev/api,aep.dev/api/longrunning;longrunning" for option "go_package" and all values must be equal.
option java_multiple_files = true;
option java_outer_classname = "OperationsProto";
option java_package = "dev.aep.aip";
option php_namespace = "AEP\\API";

extend google.protobuf.MethodOptions {
// Additional information regarding long-running operations.
// In particular, this specifies the types that are returned from
// long-running operations.
//
// Required for methods that return `aep.api.Operation`; invalid otherwise.
aep.api.OperationInfo operation_info = 1049;
}

// Manages long-running operations with an API service.
//
// When an API method normally takes long time to complete, it can be designed
// to return [Operation][aep.api.Operation] to the client, and the
// client can use this interface to receive the real response asynchronously by
// polling the operation resource, or pass the operation resource to another API
// (such as Google Cloud Pub/Sub API) to receive the response. Any API service
// that returns long-running operations should implement the `Operations`
// interface so developers can have a consistent client experience.
service Operations {
option (google.api.default_host) = "longrunning.example.com";

// Lists operations that match the specified filter in the request. If the
// server doesn't support this method, it returns `UNIMPLEMENTED`.
//
// NOTE: the `path` binding allows API services to override the binding
// to use different resource path schemes, such as `users/*/operations`. To
// override the binding, API services can add a binding such as
// `"/v1/{path=users/*}/operations"` to their service configuration.
// For backwards compatibility, the default path includes the operations
// collection id, however overriding users must ensure the path binding
// is the parent resource, without the operations collection id.
rpc ListOperations(ListOperationsRequest) returns (ListOperationsResponse) {
option (google.api.http) = {
get: "/v1/{path=operations}"
};
option (google.api.method_signature) = "path,filter";
}

// Gets the latest state of a long-running operation. Clients can use this
// method to poll the operation result at intervals as recommended by the API
// service.
rpc GetOperation(GetOperationRequest) returns (Operation) {
option (google.api.http) = {
get: "/v1/{path=operations/**}"
};
option (google.api.method_signature) = "path";
}

// Deletes a long-running operation. This method indicates that the client is
// no longer interested in the operation result. It does not cancel the
// operation. If the server doesn't support this method, it returns
// `google.rpc.Code.UNIMPLEMENTED`.
rpc DeleteOperation(DeleteOperationRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
delete: "/v1/{path=operations/**}"
};
option (google.api.method_signature) = "path";
}

// Starts asynchronous cancellation on a long-running operation. The server
// makes a best effort to cancel the operation, but success is not
// guaranteed. If the server doesn't support this method, it returns
// `google.rpc.Code.UNIMPLEMENTED`. Clients can use
// [Operations.GetOperation][aep.api.Operations.GetOperation] or
// other methods to check whether the cancellation succeeded or whether the
// operation completed despite cancellation. On successful cancellation,
// the operation is not deleted; instead, it becomes an operation with
// an [Operation.error][aep.api.Operation.error] value with a
// [google.rpc.Status.code][google.rpc.Status.code] of 1, corresponding to
// `Code.CANCELLED`.
rpc CancelOperation(CancelOperationRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
post: "/v1/{path=operations/**}:cancel"
body: "*"
};
option (google.api.method_signature) = "path";
}

// Waits for the specified long-running operation until it is done or reaches
// at most a specified timeout, returning the latest state. If the operation
// is already done, the latest state is immediately returned. If the timeout
// specified is greater than the default HTTP/RPC timeout, the HTTP/RPC
// timeout is used. If the server does not support this method, it returns
// `google.rpc.Code.UNIMPLEMENTED`.
// Note that this method is on a best-effort basis. It may return the latest
// state before the specified timeout (including immediately), meaning even an
// immediate response is no guarantee that the operation is done.
rpc WaitOperation(WaitOperationRequest) returns (Operation) {}
}

// This resource represents a long-running operation that is the result of a
// network API call.
message Operation {
// The server-assigned path, which is only unique within the same service that
// originally returns it. If you use the default HTTP mapping, the
// `path` should be a resource path ending with `operations/{unique_id}`.
string path = 1;

// Service-specific metadata associated with the operation. It typically
// contains progress information and common metadata such as create time.
// Some services might not provide such metadata. Any method that returns a
// long-running operation should document the metadata type, if any.
google.protobuf.Any metadata = 2;

// If the value is `false`, it means the operation is still in progress.
// If `true`, the operation is completed, and either `error` or `response` is
// available.
bool done = 3;

// The operation result, which can be either an `error` or a valid `response`.
// If `done` == `false`, neither `error` nor `response` is set.
// If `done` == `true`, exactly one of `error` or `response` is set.
oneof result {
// The error result of the operation in case of failure or cancellation.
google.rpc.Status error = 4;

// The normal response of the operation in case of success. If the original
// method returns no data on success, such as `Delete`, the response is
// `google.protobuf.Empty`. If the original method is standard
// `Get`/`Create`/`Update`, the response should be the resource. For other
// methods, the response should have the type `XxxResponse`, where `Xxx`
// is the original method name. For example, if the original method name
// is `TakeSnapshot()`, the inferred response type is
// `TakeSnapshotResponse`.
google.protobuf.Any response = 5;
}
}

// The request message for
// [Operations.GetOperation][aep.api.Operations.GetOperation].
message GetOperationRequest {
// The path of the operation resource.
string path = 1;
}

// The request message for
// [Operations.ListOperations][aep.api.Operations.ListOperations].
message ListOperationsRequest {
// The path of the operation's parent resource.
string parent = 4;

// The standard list filter.
string filter = 1;

// The standard list page size.
int32 max_page_size = 2;

// The standard list page token.
string page_token = 3;
}

// The response message for
// [Operations.ListOperations][aep.api.Operations.ListOperations].
message ListOperationsResponse {
// A list of operations that matches the specified filter in the request.
repeated Operation operations = 1;

// The standard List next-page token.
string next_page_token = 2;
}

// The request message for
// [Operations.CancelOperation][aep.api.Operations.CancelOperation].
message CancelOperationRequest {
// The path of the operation resource to be cancelled.
string path = 1;
}

// The request message for
// [Operations.DeleteOperation][aep.api.Operations.DeleteOperation].
message DeleteOperationRequest {
// The path of the operation resource to be deleted.
string path = 1;
}

// The request message for
// [Operations.WaitOperation][aep.api.Operations.WaitOperation].
message WaitOperationRequest {
// The path of the operation resource to wait on.
string path = 1;

// The maximum duration to wait before timing out. If left blank, the wait
// will be at most the time permitted by the underlying HTTP/RPC protocol.
// If RPC context deadline is also specified, the shorter one will be used.
google.protobuf.Duration timeout = 2;
}

// A message representing the message types used by a long-running operation.
//
// Example:
//
// rpc LongRunningRecognize(LongRunningRecognizeRequest)
// returns (aep.api.Operation) {
// option (aep.api.operation_info) = {
// response_type: "LongRunningRecognizeResponse"
// metadata_type: "LongRunningRecognizeMetadata"
// };
// }
message OperationInfo {
// Required. The message name of the primary return type for this
// long-running operation.
// This type will be used to deserialize the LRO's response.
//
// If the response is in a different package from the rpc, a fully-qualified
// message name must be used (e.g. `google.protobuf.Struct`).
//
// Note: Altering this value constitutes a breaking change.
string response_type = 1;

// Required. The message name of the metadata type for this long-running
// operation.
//
// If the response is in a different package from the rpc, a fully-qualified
// message name must be used (e.g. `google.protobuf.Struct`).
//
// Note: Altering this value constitutes a breaking change.
string metadata_type = 2;
}
32 changes: 32 additions & 0 deletions schemas/api/operation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Operation

An `Operation` represents a long-running operation that is the result of a
network API call.

## Schema

An `Operation` has the following fields:

- `path` is a string representing the path of the operation resource. This is
the standard `path` field used for all resources in resource-oriented APIs.

- `metadata` is an object containing service-specific metadata associated with
the operation. It typically contains progress information and common metadata
such as create time. Some services might not provide such metadata. Any method
that returns a long-running operation should document the metadata type, if
any.

- `done` is a boolean field indicating whether the operation has completed. If
the value is `false`, it means the operation is still in progress. If `true`,
the operation is completed, and exactly one of `error` or `response` is
populated.

- Two mutually exclusive fields containing the result of an operation:

- `error` is the error result of the operation in case of failure or
cancellation. Its type should match the standard error representation in a
given API or IDL (for example, `google.rpc.Status` in protocol buffer APIs).

- `response` is the normal response of the operation in case of success.
Depending on the method, this may be the empty object, the resource on which
the operation is performed, or a custom response.
Loading