-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and modernize AIP-151: Long-running operations. #104
Conversation
The changes are pretty broad, and include: 1) Refer to operations rather than status monitors. This is based on discussion in Slack with Luke Sneeringer, who originally adopted this AEP. 2) Add references to the common components repo (aep-dev/aep) and perform corresponding cleanup in the examples. This PR corresponds to aep-dev/aep-components#8.
Regarding "operation" vs. "status monitor": The term "status monitor", AFAICT, originates from https://datatracker.ietf.org/doc/html/rfc7231#section-6.3.3:
My read of this is:
One argument in favor of "operation": the resource we use for LROs represents the operation itself, and its fields are properties of the operation. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine you'll want to wait for @mkistler's feedback here, but I'll approve from my review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I am concerned that the term "operation" is overloaded but I think it is far more important to get the first round of AEPs adopted, so let's go with operation for now.
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Thanks! I'm going to merge this now for the sake of incremental progress, but I still want us to invest in agreement on this issue soon, because I think this will be hard to change later. If the name should be "status monitor" then we should have an |
The changes are pretty broad, and include:
This PR corresponds to aep-dev/aep-components#8.