Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indexing in UnstructuredRepertoire intra batch comp #185

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

LisaCoiffard
Copy link
Collaborator

@LisaCoiffard LisaCoiffard commented Jul 4, 2024

Related issues: N/A

Quick fix to select the current fitness in intra batch comp in the add method of unstructured repertoire. The current indexing will fail if any of the descriptors in the batch have nan values (e.g. when re-initialising the repertoire in AURORA, after training the auto-encoder).

This PR introduces:

  • change indexing of fitnesses to use current_index in intra batch comp rather than 0th knn_relevant_indices.

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written
  • relevant section added to the documentation
  • example notebook added to the repo
  • clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

[List here potential observations made and/or improvements that could be made in the future. If relevant, open issues for those.]

@LisaCoiffard LisaCoiffard marked this pull request as ready for review July 4, 2024 08:40
@Lookatator Lookatator self-requested a review August 19, 2024 22:26
@Lookatator
Copy link
Member

Hi @LisaCoiffard, thank you very much for the PR! Could you fix the style issue in the CI, so that I can merge it? :D

@Lookatator Lookatator changed the base branch from main to develop August 20, 2024 08:54
@Lookatator Lookatator added the bug Something isn't working label Aug 30, 2024
@Lookatator Lookatator added this to the v0.4.0 milestone Aug 30, 2024
@Lookatator Lookatator modified the milestones: v0.4.0, v0.4.1 Sep 5, 2024
@LisaCoiffard LisaCoiffard changed the base branch from develop to main September 19, 2024 13:06
@LisaCoiffard LisaCoiffard changed the base branch from main to develop September 19, 2024 15:47
@LisaCoiffard
Copy link
Collaborator Author

LisaCoiffard commented Sep 19, 2024

@Lookatator Fixed this issue! You can merge it :)

@Lookatator Lookatator modified the milestones: v0.4.1, v0.5.0 Sep 20, 2024
@Lookatator Lookatator merged commit 14f30f3 into adaptive-intelligent-robotics:develop Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants