Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production release #165

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Production release #165

merged 7 commits into from
Sep 25, 2024

Conversation

cristinamullin
Copy link
Collaborator

@cristinamullin cristinamullin commented Sep 16, 2024

Result value is not numeric (text) OR result value is NA and no detection limit value is provided
@cristinamullin
Copy link
Collaborator Author

@hillarymarler @wokenny13 Can you think of any recent updates to the TADA package that might impact the Shiny application & require updates here?

@wokenny13
Copy link
Collaborator

I am trying to think if any recent updates would impact the functionality and running of the TADA R shiny application.

My initial thoughts are no. There has been updates to the continuous data function with its speed and usability. Some text fixes involved with NAs and other minor fixes to Utilities.R functions. There was an incorporation of an additional scatterplot for other variables aside from Characteristic names (TADA_GroupedScatterplot).

I don't think these updates would impact any of the current outputs in the Shiny application.

the dropdown query options should be updated frequently

the siteid list could not be updated. this is a WQP issue. for now, I removed the siteid option here.
@cristinamullin
Copy link
Collaborator Author

I am trying to think if any recent updates would impact the functionality and running of the TADA R shiny application.

My initial thoughts are no. There has been updates to the continuous data function with its speed and usability. Some text fixes involved with NAs and other minor fixes to Utilities.R functions. There was an incorporation of an additional scatterplot for other variables aside from Characteristic names (TADA_GroupedScatterplot).

I don't think these updates would impact any of the current outputs in the Shiny application.

Thanks for the reminder - I just added the continuous data function to the flag tab.

@cristinamullin cristinamullin self-assigned this Sep 18, 2024
@cristinamullin cristinamullin merged commit b716e69 into develop Sep 25, 2024
6 checks passed
@cristinamullin cristinamullin deleted the 8-23-24-cm branch September 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants