-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production release #165
Production release #165
Conversation
cristinamullin
commented
Sep 16, 2024
•
edited
Loading
edited
- removes development banner
- update mod_query_data.R with updates from Added filters Country and Provider to Load tab to #164 (fixes for 3 issues - Fix characteristic group filter on import tab #140 Fix characterisitic group filter on import tab, Import tab missing country code filter #146 Import tab missing country code filter, and Add providers as a filter option on import tab #129 Add providers as a filter option on import tab)
- improve flag prompt wording (Result value is not numeric (text) OR result value is NA and no detection limit value is provided)
- removes lwgeom from imports in description file
- removes siteid query option because I was not able to generate a list of valid siteids (https://www.waterqualitydata.us/data/Station/search?mimeType=csv&zip=no&providers=NWIS&providers=STEWARDS&providers=STORET")$MonitoringLocationIdentifier) when updating the pick lists for all query filters. All other lists have been updated
Result value is not numeric (text) OR result value is NA and no detection limit value is provided
@hillarymarler @wokenny13 Can you think of any recent updates to the TADA package that might impact the Shiny application & require updates here? |
I am trying to think if any recent updates would impact the functionality and running of the TADA R shiny application. My initial thoughts are no. There has been updates to the continuous data function with its speed and usability. Some text fixes involved with NAs and other minor fixes to Utilities.R functions. There was an incorporation of an additional scatterplot for other variables aside from Characteristic names (TADA_GroupedScatterplot). I don't think these updates would impact any of the current outputs in the Shiny application. |
the dropdown query options should be updated frequently the siteid list could not be updated. this is a WQP issue. for now, I removed the siteid option here.
Thanks for the reminder - I just added the continuous data function to the flag tab. |
update drop down list