-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import tab missing country code filter #146
Comments
On my computer, I have added this field to the UI and got it passed into the TADA query function. I need to learn which shiny ui element allows creating select list that has different strings for value and displayed in the list i.e. CA and Canada. The one used in other select list only accepts a value and displays it also i.e. CA and CA. |
To add the new filter I added code to mod_query_data.R Get and prepare the filter options
Add the new UI element
Tweak the added new UI element
Add code to process argument for new UI element if selected
Finally, use it in the query that actually gets the data
|
Use China with date range 2018-05-01 to 2018-11-01 |
Testing Use China with date range 2018-05-01 to 2018-11-01 Set Country/Ocean to 'China (People's Republic of)' Set Country/Ocean to 'Atlantic Ocean' Set Country/Ocean to 'China (People's Republic of)' and 'Atlantic Ocean' Do not set either (leave them blank) |
Is your feature request related to a problem? Please describe.
There is ocean and data from other countries in the WQP that can be queried by a "country" code.
Country {"countrycode":["EM","OA","OI","OP","ZC"]}
Gulf of Mexico (STORET)
Atlantic Ocean (STORET)
Indian Ocean (STORET)
Pacific Ocean (STORET)
Caribbean Sea (STORET)
Describe the solution you'd like
Add country code filter on import tab. We could call it "country/ocean" to make it clear that users can search for oceans there as well. Generate list of countries and oceans from this domain:
FIPS code that identifies a country (e.g. countrycode = "CA" for Canada). See https://www.waterqualitydata.us/Codes/countrycode for options.
The text was updated successfully, but these errors were encountered: