Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix characteristic group filter on import tab #140

Closed
cristinamullin opened this issue Mar 11, 2024 · 2 comments · Fixed by #165
Closed

Fix characteristic group filter on import tab #140

cristinamullin opened this issue Mar 11, 2024 · 2 comments · Fixed by #165
Assignees

Comments

@cristinamullin
Copy link
Collaborator

The Characteristic Group filter on the data import tab should allow for multiple selections (see WQP example below). It currently only allows the user to select one.

image
@cristinamullin cristinamullin changed the title Characteristic Group Fix characteristic group filter on import tab Jun 4, 2024
@JamesBisese
Copy link
Collaborator

This is done on my computer.

Added multiple = TRUE where widget UI is created, then changed test where input is prepared for submission
Changed test from length(input$chargroup) == 0 to this is.null(input$chargroup)

JamesBisese added a commit to JamesBisese/TADAShiny that referenced this issue Jun 5, 2024
Updates (should be) only to mod_query_data.R and are fixes for 3 issues - USEPA#140 Fix characterisitic group filter on impor tab, USEPA#146 Import tab missing country code filter, and USEPA#129 Add providers as a filter option on import tab.
@JamesBisese
Copy link
Collaborator

Testing

Date range 2018-05-01 to 2018-05-31
Set Characteristic Group 'Biological'
Your dataset contains 444 unique results from 89 monitoring location(s) and 7 unique organization(s).

Set Characteristic Group 'Biological' and 'Physical'
... runs forever, but does not crash
... eventually I closed the browser rather than wait for a huge dataset to be loaded.

Date range 2018-05-01 to 2018-05-02
Set Characteristic Group 'Biological', 'Sediment'
Your dataset contains 125 unique results from 59 monitoring location(s) and 14 unique organization(s).

Date range 2018-05-01 to 2018-05-02
Set Characteristic Group 'Biological'
Your dataset contains 4 unique results from 4 monitoring location(s) and 1 unique organization(s).

Date range 2018-05-01 to 2018-05-02
Set Characteristic Group 'Sediment'
Your dataset contains 121 unique results from 55 monitoring location(s) and 14 unique organization(s).

Date range 2018-05-01 to 2018-05-02
Set Characteristic Group (leave blank)
... runs a long time, but does not crash when no Characteristic Group filter is applied.
Your dataset contains 115,971 unique results from 4,170 monitoring location(s) and 203 unique organization(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants